Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More validation of WDLs #181

Open
SHuang-Broad opened this issue Oct 29, 2021 · 2 comments
Open

More validation of WDLs #181

SHuang-Broad opened this issue Oct 29, 2021 · 2 comments
Assignees
Labels
Cromshell 2 Issues related to Cromshell 2.0 enhancement New feature or request

Comments

@SHuang-Broad
Copy link
Contributor

womtool validates based on syntax of the WDL, but the command block—a lot of times just bash—sometimes have errors and I'd guess few people run linters on the the command block with their IDE or text editor.

So, it makes sense for cromshell2.0 to validate at an ever deeper level, e.g.
https://stackoverflow.com/questions/171924/how-do-i-syntax-check-a-bash-script-without-running-it

I can take this on.

@SHuang-Broad SHuang-Broad added enhancement New feature or request Cromshell 2 Issues related to Cromshell 2.0 labels Oct 29, 2021
@SHuang-Broad SHuang-Broad self-assigned this Oct 29, 2021
@lbergelson
Copy link
Member

This is an amazing idea. Yes please!

@jonn-smith
Copy link
Collaborator

jonn-smith commented Oct 29, 2021

Ooh. This is a good idea.

Make sure to allow for the substitutions that cromwell makes (i.e. ~{varname} and ${varname} and potentially others depending on the command block itself). This will make the linting a little more complicated because the dollar sign dereferencing is also valid bash syntax, but the tilde symbol dereferencing is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cromshell 2 Issues related to Cromshell 2.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants