Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add a command to validate WDLs through cromshell. #261

Closed
bshifaw opened this issue Jun 28, 2023 · 2 comments · Fixed by #265
Closed

Request to add a command to validate WDLs through cromshell. #261

bshifaw opened this issue Jun 28, 2023 · 2 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request

Comments

@bshifaw
Copy link
Collaborator

bshifaw commented Jun 28, 2023

Problem:

  • Before running a workflow a user needs to validate their workflow, needing to switch to another tool like womtool or miniwdl is possible but it would be more streamlined to use one tool.
  • When submitting a workflow to Cromwell, Cromwell will automatically pass the workflow through validation before running. However, the miniwdl validation can point out the issues at each line which is friendlier to new users.

Request:
Add a wrapper command for miniwdl to validate WDLs through cromshell.

cromshell validate helloworld.wdl

@bshifaw bshifaw added the enhancement New feature or request label Jun 28, 2023
@jamesemery
Copy link
Contributor

👍 @bshifaw would it be possible to make the behavior for Cromshell2 to run Womtool validate before submitting your job at all? This was a feature of the old Cromshell and it saves a lot of time and energy having to wait for the server to progress your job past "submitted" to know that you added a silly typo to your script.

@bshifaw
Copy link
Collaborator Author

bshifaw commented Jul 17, 2023

👍 @bshifaw would it be possible to make the behavior for Cromshell2 to run Womtool validate before submitting your job at all? This was a feature of the old Cromshell and it saves a lot of time and energy having to wait for the server to progress your job past "submitted" to know that you added a silly typo to your script.

Great question @jamesemery! Cromshell does end up validating before submitting to cromshell. Previously it would perform it locally which required a local installation of womtool but has shifted to using the Cromwell server womtool API (4372e03). This avoids requiring the user from installing womtool on their end. This validation "should" be close to or just as fast as validating locally but let us know if you find it slower.

@bshifaw bshifaw self-assigned this Jul 17, 2023
@bshifaw bshifaw linked a pull request Jul 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants