You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
The fs.readdir call is unnecessary and adds a lot of overhead to what is otherwise a simple synchronous function. For example, exporting a list of plugins via an index.js file in the plugins folder and utilizing that instead would work just as well and reduce overhead massively. Even if that and similar options aren't viable, making the fs.readdir call synchronous would still solve some of the overhead and come with no real downsides considering this is a function meant to be run once as the process starts.
The forced console spam as plugins are loaded is less than ideal, even if you added a way to disable it. Removing it altogether and returning an array of loaded plugins instead would work much better, and allow users to implement logging as they wish.
The text was updated successfully, but these errors were encountered:
fs.readdir
call is unnecessary and adds a lot of overhead to what is otherwise a simple synchronous function. For example, exporting a list of plugins via anindex.js
file in the plugins folder and utilizing that instead would work just as well and reduce overhead massively. Even if that and similar options aren't viable, making thefs.readdir
call synchronous would still solve some of the overhead and come with no real downsides considering this is a function meant to be run once as the process starts.The text was updated successfully, but these errors were encountered: