Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentize -d all-debug option #542

Open
guybedford opened this issue Dec 30, 2024 · 3 comments
Open

Componentize -d all-debug option #542

guybedford opened this issue Dec 30, 2024 · 3 comments

Comments

@guybedford
Copy link
Collaborator

For debugging it would be convenient to have a jco componentize -d all-debug option which would disable all features except for stdio for debugging.

@vados-cosmonic
Copy link
Contributor

What do you think about about allowing something like --disable all --enable stdio ? I think the generality of allowing disable + enable (and documenting that we handle disables first/how they combine)?

It feels like it would be hard to describe the string all-debug in the CLI help text -- maybe if it was something more descriptive like all-except-debug or something or -d preset-debug (with docs somewhere on what the "debug" preset does for feature toggling) or something...

@guybedford
Copy link
Collaborator Author

Sure, we could have disable union with enable features to allow different sets, that seems to make sense to me? I guess the question then is which takes precedence, but disable taking precedence might be fine.

I still think having a simple flag to remember would be useful. Alternatively, perhaps we just have a singular debug mode - jco componentize --debug, and perhaps that's really what we need to keep things straightforward.

@guybedford
Copy link
Collaborator Author

That all said, on a debug build you might want to disable stdio - jco componentize --debug --disable stdio, so the reverse composition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants