-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payment flow never cancel #193
Comments
@cyrilfr Thanks for issue. What is your using framework?? I confirmed work well in Angular. |
I'm using Ionic 6 with Angular 13. I pass the
|
Oh, I see. I misunderstood to your issue. Thanks. |
Stripe.presentPaymentFlow() |
@rdlabo let me know if you need extra information :) |
OK, I see. |
So we have to Thanks. |
The I'm using a Maybe I'm not understanding it well. I want to save a payment method with a |
PaymentFlow method is for separation of payment information and payment actions. Don't run
I can implement to be able to set setupIntent on PaymentSheet. But, what is the difference between using paymentIntent in this case?
This is right, but I can't find how to implement. I will talk about this with stripe team. |
The issue is related to
the console shows:
I need to save the payment method for future payment.
I hope we'll be able to distinguish between payment method selection and modal cancelation because that makes the user experience less friendly. |
You can use setupIntent is something that only makes you enter your card information and not when you want to make the payment. Please use them well. |
I don't perform a payment at this point, so setupIntent is exactly what I need. |
Ok, I understand completely. But looking at the Android logs, there doesn't seem to be a difference between submit and close. |
Memo: I've hit on a solution. let's enable setupIntent in the PaymentSheet method. The critical problem this time is trying to confirm automatically in PaymentFlow. |
I released v3.9.1-0. Please try in PaymentSheet method. Thanks. |
Thank you @rdlabo, it works! But Google Pay isn't available as a selectable payment method anymore and the countryCode param is ignored. |
I checked
Apparently this seems to be a specification. Can using Google Pay method help you? Thanks. |
I may be able to solve this problem by increasing the version of the Stripe library, but since the targetSDK is different, it is not possible to increase the version in Capacitor3 any further. |
I specifically set
I'll go with Google Pay method then. |
@cyrilfr #181 (comment) will help you? countryCode is only use on Google Pay method. So if google pay is disabled, countryCode don't set in plugin: Thanks |
OK I though it was used to preset the country when entering credit card detail. My bad. Thanks. |
Platform
Describe the bug
When you call
Stripe.presentPaymentFlow()
it opens a closable modal sheet. Unfortunately, the return of this function is inconsistent as it's not able to distinguish between the modal sheet being closed or a credit card being selected.Actually if you close it with the cross, you get the
cardNumber
of the default selected credit card and thePaymentFlowEventsEnum.Completed
event is triggered instead ofPaymentFlowEventsEnum.Canceled
. This is not what's expected.To Reproduce
Steps to reproduce the behavior:
Stripe.presentPaymentFlow()
PaymentFlowEventsEnum.Completed
being triggered and the function return the default selected card.Expected behavior
The
PaymentFlowEventsEnum.Canceled
being triggered on cancel.Edit
I tested with the iOS Simulator and that doesn't work either. The default selected payment method is returned.
Here is a screenshot taken right after
presentPaymentFlow()
. Pressing the cross is equivalent to pressing on Google Pay or on the credit card already registered, depending on the default selected payment method.The text was updated successfully, but these errors were encountered: