Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunking for ElectricalSeries when data is passed in memory. #1184

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Jan 24, 2025

Should fix #1099

@h-mayorquin h-mayorquin self-assigned this Jan 24, 2025
@h-mayorquin h-mayorquin changed the title Fix chunking for ElectricalSeries when data is passed in Memory. Fix chunking for ElectricalSeries when data is passed in memory. Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (96dfdff) to head (30e1749).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/tools/testing/mock_interfaces.py 17.85% 23 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   90.69%   89.37%   -1.32%     
==========================================
  Files         129      129              
  Lines        8189     8405     +216     
==========================================
+ Hits         7427     7512      +85     
- Misses        762      893     +131     
Flag Coverage Δ
unittests 89.37% <55.76%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._helpers/_configuration_models/_base_dataset_io.py 96.99% <100.00%> (+0.21%) ⬆️
src/neuroconv/tools/spikeinterface/__init__.py 100.00% <100.00%> (ø)
...erface/spikeinterfacerecordingdatachunkiterator.py 100.00% <100.00%> (ø)
src/neuroconv/tools/testing/mock_interfaces.py 80.26% <17.85%> (-18.89%) ⬇️

... and 20 files with indirect coverage changes

@h-mayorquin h-mayorquin marked this pull request as ready for review January 27, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: get_default_backend_configuration: auto chunk not good for time series data
1 participant