Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOC to STC-S example, with new feature to_fits_image #122

Open
fxpineau opened this issue Dec 14, 2023 · 3 comments
Open

MOC to STC-S example, with new feature to_fits_image #122

fxpineau opened this issue Dec 14, 2023 · 3 comments

Comments

@fxpineau
Copy link
Member

Several users have asked for a S-MOC into a STC-S (or Region, ...) feature.

For another subject, Daniel Durand point me to Felix Stoehr's footprintfinder.py script.

I think we have all we need to implement the feature (at least for "small" MOCs):

  • use MOC Lib Rust to_img (also used, with limited options, in MOC.display_preview) + some WCS code to create a FITS image from a MOC.
  • apply Felix's script (to be checked).

Since Felix's script is ful Python, it will be a Python only feature.
What do you think @bmatthieu3, @tboch and @ManonMarchand ?

@ManonMarchand
Copy link
Member

ManonMarchand commented Dec 14, 2023

todo list :

  • method to_fits_image (WCS code already exists in mocpy)
  • see if we can use this script (GPL3) --> felix said he could re-licence to BSD3

@tboch
Copy link
Collaborator

tboch commented Dec 15, 2023

@fxpineau : the overall strategy looks good to me, but Felix's script licence makes it incompatible with our code.

@fxpineau
Copy link
Member Author

@tboch yes: with @ManonMarchand we looked at the license yesterday.
So far the idea would be to provide a to_fits_image method in MOCPy
and then make an example/tutorial using Felix's script.
Thus it will not be a feature implemented in MOCPy but MOCPy users will know how to do it.

@ManonMarchand ManonMarchand changed the title MOC to STC-S MOC to STC-S example, with new feature to_fits_image Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants