Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

release: make a v0.2.0 release containing the grpc-gateway updates #161

Closed
odeke-em opened this issue Jan 8, 2019 · 4 comments
Closed

release: make a v0.2.0 release containing the grpc-gateway updates #161

odeke-em opened this issue Jan 8, 2019 · 4 comments
Assignees
@bogdandrutu @songy23
Labels
release

Comments

@odeke-em
Copy link
Member

odeke-em commented Jan 8, 2019

There have been additions of the grpc-gateway in #157 and #156

Could we please make a new release, otherwise currently unable to use this feature so that we can properly use go modules otherwise right now doing say GO111MODULE=on go get github.com/census-instrumentation/opencensus-proto@master produces github.com/census-instrumentation/[email protected] whose git tag is v0.0.3 yet the currently released and highest version is v0.1.0 which then creates a conflict

$ GO111MODULE=on go get github.com/census-instrumentation/opencensus-proto@master contrib.go.opencensus.io/exporter/ocagent@master
go: finding github.com/census-instrumentation/opencensus-proto master
go: finding contrib.go.opencensus.io/exporter/ocagent master
go get: inconsistent versions:
	contrib.go.opencensus.io/exporter/[email protected] from contrib.go.opencensus.io/exporter/ocagent@master requires github.com/census-instrumentation/[email protected] (not github.com/census-instrumentation/[email protected] from github.com/census-instrumentation/opencensus-proto@master)
@odeke-em odeke-em mentioned this issue Jan 8, 2019
Merged
@songy23 songy23 self-assigned this Jan 8, 2019
@songy23 songy23 added the release label Jan 8, 2019
This was referenced Jan 8, 2019
Merged
Merged
odeke-em added a commit to census-instrumentation/opencensus-service that referenced this issue Jan 10, 2019
@odeke-em
example/main.go: avoid using clashing/unpublished ocagent version
af92f35 
Because of clashes with unpublished versions of opencensus-proto
as per census-instrumentation/opencensus-proto#161

we can't update ocagent to use the view.Exporter code, because
the unpublished opencensus-proto is what provides support for
the grpc-gateway. Hence this commit checks in the previous version
of example/main.go until that release.
odeke-em added a commit to census-instrumentation/opencensus-service that referenced this issue Jan 10, 2019
@odeke-em
example/main.go: avoid using clashing/unpublished ocagent version
bc5b4e5 
Because of clashes with unpublished versions of opencensus-proto
as per census-instrumentation/opencensus-proto#161

we can't update ocagent to use the view.Exporter code, because
the unpublished opencensus-proto is what provides support for
the grpc-gateway. Hence this commit checks in the previous version
of example/main.go until that release.
@bogdandrutu
Copy link
Contributor

Is this done?

@songy23
Copy link
Contributor

songy23 commented Jan 15, 2019

Not yet, waiting on approval of #167.

@songy23
Copy link
Contributor

songy23 commented Jan 16, 2019

Waiting on #152.

@odeke-em odeke-em mentioned this issue Mar 6, 2019
Merged
@songy23
Copy link
Contributor

songy23 commented Mar 7, 2019

Bumping this up - the version inconsistency in proto has caused troubles in OC-Agent and Agent Exporters. We need to publish a new release to Maven, otherwise the Java Agent exporters won't work with Agent. @odeke-em also saw a bunch of issues from users, where they depend on an outdated proto version in Go exporter and it didn't work with the latest Agent.

@bogdandrutu are there any other blockers for the new release? IMO #152 can roll over to the next release.

@songy23 songy23 mentioned this issue Mar 13, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bogdandrutu bogdandrutu

@songy23 songy23

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bogdandrutu @odeke-em @songy23