-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] not compatible with React 19 #620
Comments
@christianalfoni looks like the fix (at least so that overmind/react doesn't throw) would be quite easy: https://github.com/microsoft/use-disposable/pull/32/files#diff-5971f63da29997ff64996c0f14497c4756ed24cf15d181141ea6a8f9c8d7a376R6. Basically the internals have been moved around. Would you be able to find some time to revive Overmind for React 19 so that this awesome project can live for some more time? :D We would all appreciate it ❤️ Hopefully, I will take my chances as well to try to send a PR that fixes this issue. |
If you send a pr and everything looks good I can release it to next. |
@henri-hulski thx good to know, challenge accepted then 😃 |
@henri-hulski #621 finally here's the PR. I have tested the fix with rather large overmind+react@19 project and no errors reported. Would be great if you could review, merge and release ❤ |
due to use of SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, not compatible with React 19
The text was updated successfully, but these errors were encountered: