Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined tags #14

Open
staab opened this issue Jan 6, 2025 · 0 comments
Open

Undefined tags #14

staab opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@staab
Copy link
Collaborator

staab commented Jan 6, 2025

If you call getEditorTags with hints = true, but no hints are available on the nprofile/nevent extensions, undefined gets added to the tags array, and causes events to be invalid. We could default to an empty hint, but relay and pubkey hints are really important, so I think a better approach would be to:

  • Add getRelays option to nprofile/nevent extensions so relays can always be populated
  • Default to an empty hint if no hints are available
  • (optional) I think splitting nprofile/npub and nevent/note would improve things, since currently there's some confusing overloading going on.
@staab staab added the bug Something isn't working label Jan 6, 2025
@staab staab self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant