Fix: example of queued_interceptor_csrftoken.dart

[seunghwanly]

Referred to #2342

New Pull Request Checklist

• I have read the Documentation
• I have searched for a similar pull request in the project and found none
• I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
• I have added the required tests to prove the fix/feature I'm adding
• I have updated the documentation (if necessary)
• I have run the tests without failures
• I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

The example's misconception led users to misunderstand QueuedInterceptor. Also, with @Passer-by 's support, I added a token update policy.

#2342 (comment)

[Passer-by]

tokenRefreshDio need close

[seunghwanly]

I added closing lines for tokenRefreshDio

[Passer-by]

@seunghwanly tokenRefreshDio seems to be one-time use, can it be closed after use?

[seunghwanly]

tokenRefreshDio seems to be one-time use, can it be closed after use?

Apologies, I couldn't get it right. tokenRefreshDio is used in this if-condition block and closed. Could you guide me on where to fix it or point to specific lines?

dio/example_dart/lib/queued_interceptor_crsftoken.dart

Lines 67 to 91 in 9af8b90

	if (requestedAccessToken == tokenManager.accessToken) {
	final tokenRefreshDio = Dio()
	..options.baseUrl = 'https://httpbun.com/';
	final response = await tokenRefreshDio.post(
	'https://httpbun.com/mix/s=201/b64=${base64.encode(
	jsonEncode(AuthenticationServer.generate()).codeUnits,
	)}',
	);
	if (response.statusCode == null || response.statusCode! ~/ 100 != 2) {
	tokenRefreshDio.close();
	return handler.reject(error);
	}
	final body = jsonDecode(response.data) as Map<String, Object?>;
	if (!body.containsKey('access_token')) {
	tokenRefreshDio.close();
	return handler.reject(error);
	}
	final token = body['access_token'] as String;
	tokenManager.setAccessToken(token, error.requestOptions.hashCode);
	tokenRefreshDio.close();
	}

[Passer-by]

tokenRefreshDio好像是一次性的，用完之后可以关闭吗？

抱歉，我没能搞定。tokenRefreshDio 用在这个 if 条件块中，并且已关闭。您能指导我在哪里修复它或指出具体行吗？

dio/example_dart/lib/queued_interceptor_crsftoken.dart

Lines 67 to 91 in 9af8b90

	if (requestedAccessToken == tokenManager.accessToken) {
	final tokenRefreshDio = Dio()
	..options.baseUrl = 'https://httpbun.com/';
	final response = await tokenRefreshDio.post(
	'https://httpbun.com/mix/s=201/b64=${base64.encode(
	jsonEncode(AuthenticationServer.generate()).codeUnits,
	)}',
	);
	if (response.statusCode == null || response.statusCode! ~/ 100 != 2) {
	tokenRefreshDio.close();
	return handler.reject(error);
	}
	final body = jsonDecode(response.data) as Map<String, Object?>;
	if (!body.containsKey('access_token')) {
	tokenRefreshDio.close();
	return handler.reject(error);
	}
	final token = body['access_token'] as String;
	tokenManager.setAccessToken(token, error.requestOptions.hashCode);
	tokenRefreshDio.close();
	}

        if (requestedAccessToken == tokenManager.accessToken) {
          final tokenRefreshDio = Dio()
            ..options.baseUrl = 'https://httpbun.com/';
          
          final response = await tokenRefreshDio.post(
            'https://httpbun.com/mix/s=201/b64=${base64.encode(
              jsonEncode(AuthenticationServer.generate()).codeUnits,
            )}',
          );

          tokenRefreshDio.close();

          if (response.statusCode == null || response.statusCode! ~/ 100 != 2) {
            return handler.reject(error);
          }

          final body = jsonDecode(response.data) as Map<String, Object?>;
          if (!body.containsKey('access_token')) {
            return handler.reject(error);
          }

          final token = body['access_token'] as String;
          tokenManager.setAccessToken(token, error.requestOptions.hashCode);
        }

Would this be simpler?

[seunghwanly]

@Passer-by Thanks for the support!

[Passer-by]

LGTM

[github-actions]

Code Coverage Report: Only Changed Files listed

Package	Base Coverage	New Coverage	Difference
Overall Coverage	🟢 84.71%	🟢 84.71%	⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.71%

[AlexV525]

Some nits about the comments

[seunghwanly]

Some nits about the comments

I've incorporated the suggestions from your review into 66bab27. Thank you for your feedback :)

[AlexV525]

Thanks both @seunghwanly and @Passer-by for your continuous contributions!

[seunghwanly]

@AlexV525 @Passer-by

Quick question!

Since Future.wait runs its tasks in the same isolate, wouldn't 'Concurrency' be a more suitable term in this case? Additionally, the implemented code seems to handle the tasks one by one.

dio/dio/lib/src/interceptor.dart

Lines 404 to 431 in e7edb97

	void _handleQueue<T, V extends _BaseHandler>(
	_TaskQueue<T, V> taskQueue,
	T data,
	V handler,
	void Function(T, V) callback,
	) {
	final task = _InterceptorParams<T, V>(data, handler);
	task.handler._processNextInQueue = () {
	if (taskQueue.queue.isNotEmpty) {
	final next = taskQueue.queue.removeFirst();
	assert(next.handler._processNextInQueue != null);
	callback(next.data, next.handler);
	} else {
	taskQueue.processing = false;
	}
	};
	taskQueue.queue.add(task);
	if (!taskQueue.processing) {
	taskQueue.processing = true;
	final task = taskQueue.queue.removeFirst();
	try {
	callback(task.data, task.handler);
	} catch (e) {
	task.handler._processNextInQueue!();
	}
	}
	}
	}

[seunghwanly]

I wrote 'parallel' here

[AlexV525]

I'm not sure about the word but it seems reasonable.

[Passer-by]

Would using 'Independent Request' be better here?