Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write documentation #431

Open
ozankaymak opened this issue Jan 20, 2025 · 4 comments
Open

Write documentation #431

ozankaymak opened this issue Jan 20, 2025 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ozankaymak
Copy link
Contributor

Proposal Description

For both easier onboarding of new people and better DX, we need to write more documentation.

@ozankaymak ozankaymak added the documentation Improvements or additions to documentation label Jan 20, 2025
@ozankaymak ozankaymak self-assigned this Jan 20, 2025
@mmtftr
Copy link

mmtftr commented Jan 20, 2025

I believe we can approach this systematically. Using Rustdoc is the industry standard for documenting a crate, so I believe we can start from there. We can use this as a tracker issue to track work on documenting the codebase.

A couple of candidate tasks for the first stage:

@ekrembal ekrembal marked this as a duplicate of #430 Jan 20, 2025
@mmtftr
Copy link

mmtftr commented Jan 20, 2025

  • Another great thing would be to have a CONTRIBUTING.md that both introduces the project on an overview-level and provides guidance on how to contribute (our testing, documentation, coverage standards, PR contents, commit formatting, preferred PR merge, branch naming convention, branch explanations [dev vs main etc] etc.).
  • On a similar note, it'd be great if we adopt Doctesting, especially for simpler functions where the documentation could provide sufficient tests. A lot of unit tests could probably be rolled into doctests. Of course, some functions are way too complicated to test within doctests.

@ceyhunsen
Copy link
Member

  • I think it will be more appropriate to keep concepts in other documentations, outside of Clementine, like Clementine onboarding docs
    • Or in a separate dir called docs/
    • Readme can just include small intro to Clementine and how to run it
  • Add CONTRIBUTING.md #364 contributing.md
  • I believe we can slowly shift basic unit tests to doctests and add rustdoc support
    • It should be very good if we adopt it but there is no rush to do that rn
    • Everyone slowly switching to this will help having this habit for everyone of us, rather than single person doing all the work
    • I suggest we should push ourselves to do this in our PR's for the new codes
    • It will be nice to move basic unit tests to doctest, if one's PR touches that specific part of code or in the same context

@ozankaymak
Copy link
Contributor Author

Can you update/open issues related to this issue? @ceyhunsen @mmtftr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants