Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user.rs and find a better way to use them #454

Open
2 tasks
ozankaymak opened this issue Jan 22, 2025 · 1 comment
Open
2 tasks

Remove user.rs and find a better way to use them #454

ozankaymak opened this issue Jan 22, 2025 · 1 comment

Comments

@ozankaymak
Copy link
Contributor

Issue Description

We will not be using user.rs anymore, but we still need their functionalities for testing.

Tasks

Parts of the task:

  • Remove user.rs
  • Find a better way to include them in the tests

Deadline of the Issue

@ozankaymak ozankaymak mentioned this issue Jan 22, 2025
6 tasks
@ceyhunsen
Copy link
Member

It should be noted that all the test code must be macros. Because we use them in both unit and integration tests and one of them must include the file directly (like by specifying relative OS path to it), which was the integration tests. Reason was that we don't want to infiltrate test code into binaries (details: #181).

If we use use statements, integration tests won't compile because include paths were different (crate:: vs clementine_core::). So we decided to use only macros for this kind of stuff. They are in core/src/test_utils.rs. I suggest following the conventions. Pr that introduced this: #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants