Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase correction correction is not correct in auto-processing #2775

Closed
hamed-musallam opened this issue Nov 29, 2023 · 5 comments · Fixed by #2787
Closed

Phase correction correction is not correct in auto-processing #2775

hamed-musallam opened this issue Nov 29, 2023 · 5 comments · Fixed by #2787
Assignees
@jobo322
Labels
bug Something isn't working

Comments

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 29, 2023 •
edited
Loading

To reproduce use this test sample

Screenshot 2023-11-29 at 19 50 07
Screenshot 2023-11-29 at 19 49 53
@hamed-musallam hamed-musallam added the bug Something isn't working label Nov 29, 2023
@lpatiny
Copy link
Member

lpatiny commented Nov 30, 2023

For the carbon it was always like that AFAIK

carbon.zip

image

Concerning the proton it seems however that it is worse than before.

proton.zip

image

The spectrum should be loaded by topspin to check if we just don't load correctly the applied PH0 and PH1

@jobo322
Copy link
Member

jobo322 commented Dec 1, 2023

This problem is related with the last edition of ph0 -> 180 added as a compensation of the removal digital filter. So, it is better to check why the automatic phase correction is not able to find the correct values.

@jobo322
Copy link
Member

jobo322 commented Dec 1, 2023 •
edited
Loading

This spectrum has a group delay of 67.98 (odd number of points moved)

| topspin
Alpha Ionone_topspin_no_phase
| mestrenova
| nmrium
alpha_ionone_nmrium_no-phase

@jobo322
Copy link
Member

jobo322 commented Dec 4, 2023

Seems the 180 added phase correction based on group delay is correct. An improvement in the auto phase correction is coming on the ml-spectra-processing version 12.8.0 we will obtain

image

@jobo322
Copy link
Member

jobo322 commented Dec 4, 2023

also, for Carbon sample

image

@jobo322 jobo322 linked a pull request Dec 4, 2023 that will close this issue
fix: auto phase correction #2787
Merged
@jobo322 jobo322 moved this from 🔴 Todo to 🟠 In Progress in NMR and Cheminfo projects organisation Dec 5, 2023
@github-project-automation github-project-automation bot moved this from 🟠 In Progress to 🟢 Done in NMR and Cheminfo projects organisation Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jobo322 jobo322

Labels
bug Something isn't working
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: auto phase correction cheminfo/nmrium
3 participants
@lpatiny @jobo322 @hamed-musallam