Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#3 - Optimizations of I2C Master controller #16

Open
1 of 5 tasks
Juninho99 opened this issue Jun 5, 2024 · 1 comment · Fixed by #18
Open
1 of 5 tasks

issue#3 - Optimizations of I2C Master controller #16

Juninho99 opened this issue Jun 5, 2024 · 1 comment · Fixed by #18
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Juninho99
Copy link
Collaborator

Juninho99 commented Jun 5, 2024

Improvement: i2c_top/i2c_ctrl.sv Module

Description

We need to enhance the i2c_top.sv and i2c_ctrl.sv modules by addressing several critical issues and optimizing its performance. The following tasks have been identified for this improvement:

Tasks

  • Remove unnecessary flip-flops that are unused or redundant in the i2c_top.sv.
  • Remove unnecessary flip-flops that are unused or redundant in the i2c_ctrl.sv.
  • Fix the clock 'runt' issue occurring immediately after activation.
  • Conduct a detailed simulation to observe state transitions, paying special attention to clock behavior during these transitions.
  • Eliminate one of the states in the i2c_ctrl.sv module, as it appears to be unnecessary and redundant.

Details

1. Remove Unnecessary Flip-Flops

There are several flip-flops in the current design that are either not used or are redundant. These need to be identified and removed to streamline the module.

2. Fix Clock 'Runt' Issue

There is a known issue where a 'runt' clock pulse appears immediately after activation. This needs to be fixed to ensure stable clock signals throughout the module's operation.

3. Detailed Simulation of State Transitions

A thorough simulation is required to closely observe the transitions between states. Particular focus should be on the behavior of the clock signal during these transitions to ensure smooth and error-free operation.

4. Eliminate Redundant State

There appears to be a redundant state in the state machine. This state should be identified and removed to simplify the state machine and improve the efficiency of the module.

@Juninho99 Juninho99 self-assigned this Jun 5, 2024
@Juninho99 Juninho99 linked a pull request Jun 6, 2024 that will close this issue
@Juninho99 Juninho99 reopened this Jun 6, 2024
@chili-chips-ba chili-chips-ba added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 10, 2024
@chili-chips-ba chili-chips-ba changed the title issue#3 issue#3 - Optimizations of I2C Master controller Jul 19, 2024
@chili-chips-ba
Copy link
Owner

@Juninho99 is this ripe now for closure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants