Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#6 - csi_rx_align_word #21

Open
Juninho99 opened this issue Jun 30, 2024 · 2 comments
Open

issue#6 - csi_rx_align_word #21

Juninho99 opened this issue Jun 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Juninho99
Copy link
Collaborator

Juninho99 commented Jun 30, 2024

Issue: Review of csi_rx_align_word.sv module

We need to review the implementation of csi_rx_align_word.sv module.

Modified version, as proposed in the issue#5 branch, works properly in simulation. However, something isn't right for the version that's currently on the main branch.

Below are two waveforms that show the difference.

What we see on the first wave is that valid_out is lined up with word_out, while also filtering out the B8 sync bytes, which is indeed the design intent.
image

On the second wave however, valid_out is encompassing the B8. That causes downstream failures. Also, few other signals (wait_for_sync, packet_done, etc.) are not looking right in the second wave.
image

@Juninho99 Juninho99 self-assigned this Jun 30, 2024
@Juninho99 Juninho99 changed the title Review of csi_rx_align_word.sv module issue#6 Jun 30, 2024
@chili-chips-ba chili-chips-ba added bug Something isn't working documentation Improvements or additions to documentation labels Jul 10, 2024
@chili-chips-ba
Copy link
Owner

The original bug was about misalignment of VLD and DATA, and simple to fix. However we still cannot declare the align_word module fully tested, as the existing testbench does not exercise its primary function.

To close this issue, static lane-to-lane skew needs to be added to the traffic generator. The test should cover at least the following two cases:

  1. when lane-to-lane skew is within deskewing range of this module, which is 2 clock cycles
  2. when lane-to-lane skew exceed that range

Similarly, we cannot declare that align_byte module is fully tested without introducing bit skew into traffic generator for each lane.

@Juninho99, let's improve the sim setup with these must-have capabilities for further progress on this ticket.

@chili-chips-ba chili-chips-ba changed the title issue#6 issue#6 - csi_rx_align_word Jul 19, 2024
@chili-chips-ba
Copy link
Owner

@Juninho99 please consider closing this ticket. If there are any outstanding DV-related activities, open a new task issue to track them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants