add large link embeds #1560
Closed
add large link embeds #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
changed the title
|
Preview: https://1560--pr-cinny.netlify.app |
ultra wide / ultra tall but otherwise small images are cropped if too small in one dimension (minimum size changed to 32x32 in timeline)
center is more likely to have relevant content than top left
WebFreak001
force-pushed
the
large-link-embeds
branch
from
0bbdaf9 to
4c91fb7
Compare
|
|
|
the dependency PRs need to be merged first before this PR can be used or edited further Can you check out my |
Ah, makes sense, I didn't take into account that the preview might not have those. Works just fine on said branch :) |
|
Closing as not plained |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR depends on #1555 and also gets visual improvements from #1554 and #1556, which are already rebased here - but if you don't want to merge those into master I can remove the commits from this PR again as well.
Set as draft while the other PRs are still open, since this PR has the commits from the other PRs included as well (only last commit is relevant to this PR), but some people I chat with wanted to have this early so I already publish it here
This makes images that are sent as links embed as if they were uploaded as images, using the URL preview function. Good for when people are using their own image uploaders or linking to content on the web. Although currently the implementation does not fully mirror how regularly uploaded images look like. Small images are centered inside a static 400px width gray embed box, transparent images also show the gray embed box background.
Clicking on the images to view them fullscreen using the image viewer works well though.
Sample: