Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not able to edit large room names and added limit to room's name upto 50 #2104

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix not able to edit large room names and added limit to room's name upto 50 #2104

wants to merge 3 commits into from

Conversation

Vishawdeep-Singh
Copy link

@Vishawdeep-Singh Vishawdeep-Singh commented Dec 21, 2024 •
edited
Loading

Description

Fixes #2092

Before:

Screen.Recording.2024-12-21.at.3.52.09.PM.mov

After my changes :

Screen.Recording.2024-12-21.at.3.54.04.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Vishawdeep-Singh
Added word break for room name in room's setting card and also set a …
daf58e4 
…limit to 50 characters when creating a new room
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Vishawdeep-Singh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Dec 21, 2024
@ajbura
@Vishawdeep-Singh has signed the CLA in cinnyapp/cinny#2104
25f3f15
@Vishawdeep-Singh
Copy link
Author

@ajbura Can you also review this please ?

ajbura
ajbura requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, preventing user from entering room name above 50 char is a no go, the attached issue can be fixed with css styles only.

@Vishawdeep-Singh
Copy link
Author

Hey, preventing user from entering room name above 50 char is a no go, the attached issue can be fixed with css styles only.

@ajbura Hey,I want your opinion on this . Should i make room name Y-axis scrollable and keep edit option first OR just simply truncate the text.

@ajbura
Copy link
Member

ajbura commented Jan 6, 2025

word break will put the text in next line and keep the edit button visible

@Vishawdeep-Singh
Copy link
Author

word break will put the text in next line and keep the edit button visible

@ajbura Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura Awaiting requested review from ajbura

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to edit a large room name
2 participants
@Vishawdeep-Singh @ajbura