Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port numbers should not be shown with commas in Dashboards #540

Closed
mmguero opened this issue Dec 19, 2024 · 1 comment
Closed

port numbers should not be shown with commas in Dashboards #540

mmguero opened this issue Dec 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working dashboards Relating to Malcolm's OpenSearch Dashboards interface opensearch Relating to Malcolm's use of OpenSearch UI Relating to general UI experience
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Dec 19, 2024

General practice is not to include commas in port numbers (e.g., 51200 vs. 51,200).

Dashboards management allows this to be configured:

  • dashboard management > index patterns > arkime_sessions3* > search "destination.port"
  • hit the edit pencil and make this edit:
    • Format: Number
    • Numeral.js format: 0
  • hit save.

We ought to figure out how to do the same thing for all port values in the index template when creating index patterns.

@mmguero mmguero added bug Something isn't working dashboards Relating to Malcolm's OpenSearch Dashboards interface opensearch Relating to Malcolm's use of OpenSearch UI Relating to general UI experience labels Dec 19, 2024
@mmguero mmguero added this to the v25.01.0 milestone Dec 19, 2024
@mmguero mmguero added this to Malcolm Dec 19, 2024
@mmguero mmguero moved this to Todo (develop) in Malcolm Dec 19, 2024
@mmguero mmguero self-assigned this Jan 13, 2025
@mmguero mmguero moved this from Todo (develop) to In Progress in Malcolm Jan 13, 2025
@mmguero
Copy link
Collaborator Author

mmguero commented Jan 14, 2025

This actually gets resolved by #551 , as we specify the label template for these values the commas don't get inserted anyway.

@mmguero mmguero closed this as completed Jan 14, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Malcolm Jan 14, 2025
This was referenced Jan 17, 2025
@mmguero mmguero moved this from Done to Released in Malcolm Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboards Relating to Malcolm's OpenSearch Dashboards interface opensearch Relating to Malcolm's use of OpenSearch UI Relating to general UI experience
Projects
Status: Released
Development

No branches or pull requests

1 participant