Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more fields and a direct link to the DNB catalog page in comments #11

Open
bertholdm opened this issue Sep 20, 2024 · 3 comments

Comments

@bertholdm
Copy link

Hello,
in order to have the book information as detailed as possible, it would be nice if all catalog fields could be taken into account (possibly selectable as an option). The information such as size and format (in data field 300) could be written in the comment field of Calibre (possibly as a table).
In my own plug-ins I also provide the direct link to the source (here, for example, https://d-nb.info/364405880).
In any case, thanks for the plug-in!

@citronalco
Copy link
Owner

In your example, this would be following additional information in the comment field:

  • Umfang/Format 32 S. ; 8
  • Preis -.50
  • Beziehungen Fliegergeschichten ; 154
  • Anmerkungen Status nach VGG: vergriffen

Maybe I am wrong, but I don't see an added benefit for 99.9% of the users.
Nevertheless: If you want to implement it the way you described above (having it optional, default is off), I will happily merge it. Keep in mind that comments are usually in plain text, not HTML.

@citronalco
Copy link
Owner

@bertholdm I borrowed some lines from your fork to make thei gnore-series-name-if-same-as-publisher and ignore-series-by-regex configurable by users.

https://github.com/bertholdm/calibre-dnb/blob/0e12898865c88e4182a94cabcf5fa1f01b0b1d3b/config.py#L296C29-L296C50 should not get KEY_FOREWORD_PATTERNS but KEY_UNWANTED_SERIES_NAMES

@bertholdm
Copy link
Author

Hello,
Thanks for the error hint; the text constant ist now replaced.
And please borrow what you want. The code works for my books so far, but it's a mess. At the moment i've no time for refactoring.
All the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants