-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final PDF report for Transport Infratructure Studies (TM Studies) #148
Comments
We've been thinking about this for a while. The approach that we are considering now is as follows:
What do you think? Are any of them feasible? Which one would you prefer? An additional PDF would be the one that's generated by the CSIS, we do not have any control over that so we think that should be an option too so these studies also produce a PDF with the information stored in the CSIS (EU-GL, adaptation options, etc.). This way we ensure that we have the adaptations options that the TM does not handle. |
@ghilbrae yes, it would be a possibility to simply generate two separate PDFs - one in the CSIS with all the information that the CSIS has available and another one in the TM with all the information that the TM has available. But I don't know how useful it would be for the users if they had to look up information about their study in two separate PDFs.
This sounds to me like you want to create a separate PDF for each individual Step of the Study, is that correct? To me that sounds like an overkill - it would be enough to just create one PDF with all the steps. I was thinking that maybe the TM could send us the missing information and the CSIS takes care of the whole PDF. What information does the TM have, which is not in the CSIS - AFAIK it's the tables and maps, right? How were you planning to get those into the PDF? Probably also create snapshots of them, so that they can be added to the PDF as images. If that's the case, you could either directly push those images into the CSIS or just notify us that new images for a study are available and the CSIS will then grab them. What do yo think? |
If you already have a working PDF generator in the TM then we can leave it at that for now and in the CSIS we will just link to the created PDF in the TM. And we will offer a second PDF inside the CSIS with additional information, which is not included in the TM. |
We've discussed this a bit. One way to include the TM specific information in the general report would be to access all necessary information in a json call. Of course, it would be possible to send ready made PDFs to have them embedded (I suppose PHP can do that), but it would be very difficult to have consistent aesthetics. |
Sending generated PDFs between the CSIS and the TM seem unnecessary to me. If the TM creates a (partial) PDF, it wouldn't be necessary for the CSIS to also have an actual copy of it. In the CSIS we could just show a link to the user, where he/she could access your PDF.
I agree. This would be a simple solution. Question: Who will create the PDFs - CSIS or TM? |
@ghilbrae if you like we can have a short dedicated telco regarding this topic somewhen this week. WDYT? |
How about tomorrow? We can meet from 9.00 to 10.30 or after 12. Another option could be to meet after Monday's meeting. |
Ok let's make it 9:30 tomorrow. We really shouldn't need more than an hour for that. I'll send you an invite. |
So after our discussion today, we decided the following approach:
In the future, we could then possibly switch to a Single-PDF approach by either providing the CSIS or the TM with the missing information from the other tool. Things that need to be considered for that:
|
Is this done yet? |
@rapto what's the status for the PDF generation in the TM? |
@patrickkaleta as discussed on Monday, we are able to produce PDFs for testing now. The URL that should be used is https://clarity.saver.red/reference/ID/pdf The resulting PDF is blank for now, but it should be enough for testing the integration. We'll let you know when the full PDF is available. As discussed previously, we think that the current report (the one generated by the CSIS) should still be available along with the one coming form the TM. |
I've included the link to the PDF generated by the TM. On the Study Summary page the available PDF(s) are now listed in the right sidebar. @ghilbrae as you said, the page is ATM mostly blank, so I'm going to leave this issue open, so that you can keep us updated about the progress on your side. |
Perfect! Thank you very much. I'll update the issue when the PDF is less blank 😄 |
Subtask of #134
Comment from Angela:
@ghilbrae as discussed previously, the TM will generate the final report and the CSIS will provide additional summaries for the Adaptation options.
How exactly are we going to do this? Would it be enough for the TM if CSIS provides a REST endpoint where the TM could request details about all included adaptation options. That information could then included in your final PDF report? WDYT?
The text was updated successfully, but these errors were encountered: