Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO appraisal step for advanced screening study #177

Closed
5 tasks done
DenoBeno opened this issue Jul 13, 2020 · 14 comments
Closed
5 tasks done

AO appraisal step for advanced screening study #177

DenoBeno opened this issue Jul 13, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@DenoBeno
Copy link

DenoBeno commented Jul 13, 2020

Summary: in advanced screening, differentiate between "AO Identification" and "AO appraisal" steps.

  • Define new templates for these two steps and adm to test study type
  • In AO identification allow the users to explore the available adaptation options
  • In AO appraisal, allow the users to define the adaptation strategy
  • In AO appraisal, allow the users to trigger re-calculation
  • In AO appraisal, allow the users to explore the difference between situation with and without adaptation options.
@DenoBeno DenoBeno added the enhancement New feature or request label Jul 13, 2020
@DenoBeno
Copy link
Author

DenoBeno commented Jul 13, 2020

I have defined a new "test" workflow that extends and improves the "Advanced screening". Some of it works as designed, some doesn't and will require your attention:

  1. Possibility to trigger re-calculatioon directly from AO Appraisal step (easy to implement, I presume)
  2. Possibility to use scenario analysis in this step. Currently nothing is shown at all, no idea why.
  3. Possibility to visualize before/after situation in a map component. Currently the map works, but this is not possible.
  4. Ideally, we should also be able to show simple cost / benefit analysis - currently not available AFAIK.

Test study is here: https://csis-dev.myclimateservice.eu/study/163/view/intro

I have linked it to an existing study so that I can see how emikat results are displayed. Triggering new calculation doesn't work on dev server.

@patrickkaleta
Copy link

2. Possibility to use scenario analysis in this step. Currently nothing is shown at all, no idea why.

Reason for that was that the View had a filter applied, which allowed only GL-steps with the EU-GL methodology tax. term = "Risk and Impact Assessment". I've removed that filter and now the Scenario Analysis app is also shown in this AO appraisal step.

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Jul 23, 2020

Possibility to visualize before/after situation in a map component. Currently the map works, but this is not possible.

Adaptation Map is now implemented on DEV instance and can be tested here:

image

Test Template: Adaptation Options Appraisal is also updated. Note that the maps don't show any difference, this is probably just a matter of updating the styles in EMIKAT WMS. Furthermore, impact with adaptation options applied is still siglty higher. See also #154 (comment)

Moreover, I've updated all tables to include all columns and adaptation scenarios when downloading the tables as JSON or CSV, so you can compare data offline.

@p-a-s-c-a-l

This comment has been minimized.

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Jul 24, 2020

Scenario Analysis has been updated on CSIS-DEV. ATM all indicators available in EMIKAT view.2994 are shown, Pluvial Flood indicators yet to come.

image

I'm not sure about the cost and the unit of "Heat Wave Impact", though. Furthermore, adaptation scenarios as well as some values randomly appear and disappear.

@DenoBeno Furthermore, there is no difference between Scenario Analysis in RA/IA and AOAP Step. So the only difference is the Map, which shows Baseline (left) and Adaptation Scenarios (right) in the new AOAP step. I don't know if this minor difference really justifies a new AOAP step or if we better just change the map in the RA/IA step.

@p-a-s-c-a-l
Copy link
Member

Now with pluvial flood:

image

Example Study 25 on CSIS DEV.

Note: Scenario Analysis on PROD-CSIS is broken since EMIKAT API changed.

Before I make a new public release, please let me know if you want any change of indicator name / units @claudiahahn @DenoBeno @mattia-leone

@claudiahahn
Copy link

This might be an unqualified comment, but without an explanation of the indicators they'll not be very helpfull for the user.
I have been on vacation, so maybe I have missed the discussion about that. But it seems that the indicators are not explained in any of the tabs under the "Risk/Impact" step. What does heat wave impact mean, or damage class mean?

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Jul 29, 2020

What does heat wave impact mean, or damage class mean?

This is a good question. I think this information is somewhere hidden in vulnerability whereas I'm not sure whether is this conceptually consistent or not.

Anyway, this should be explained in the respective resource so that it is visible on the RA/IA data tab.

@claudiahahn
Copy link

ah, true. There it is. Thanks @p-a-s-c-a-l
In addition to the explanation in the resource itself, it might also be an option to add a short note next to "indicator" under the Risk/Impact step and to link to the vulnerability site.
something like: "Information about the indicators can be found here"

@DenoBeno
Copy link
Author

DenoBeno commented Aug 8, 2020

We can very easily add texts. Either in introduction of the step or at the page. Just tell us what to write.

@DenoBeno
Copy link
Author

DenoBeno commented Aug 8, 2020

@p-a-s-c-a-l :

There is indeed no difference between Scenario Analysis in RA/IA and AOAP steps. Except for the maps.

I don't really care, but if this turns out to be a problem, we can disable everything except for the map in RA/IA step.

My vote is on "let it be for now " .

Even better would be to hide all "with AO" from RA/IA step, but again I don't see this as important.

@claudiahahn
Copy link

We can very easily add texts. Either in introduction of the step or at the page. Just tell us what to write.

on that page it would be good to insert: "Information about the indicators are available in the "Vulnerability" step, under the "Table" tab".

@DenoBeno
Copy link
Author

I have added the missing files to vulnerability descriptions on CSIS. Synchronization failed to copy them, so I did it per hand now. They could disappear again on next sync though.

@patrickkaleta
Copy link

Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants