-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new Studies in the CSIS #83
Comments
So we'll keep the steps? I remember there was a discussion / proposal to remove them entirely. 😕 Anyway. ATM the information in newly created steps is all we need. EMIKAT id is added to the study by this trigger, right? Note: Eventually we switch from ReactMount to iFrames, then we have to update the default Map and Table Components. |
I'm aware of the discussion started by @DenoBeno to remove the GL-Step entity type and have it all in the study group. But as you rightly mentioned this would have a major impact on all we have so far developed. So (to my recollection) the conclusion was to continue the way it is right now, while Denis works in parallel on his proposal without disrupting our current implementation.
Correct.
Updating the corresponding Business rules to include the updated components is not a problem. For already existing studies with GL-steps showing the then obsolete components, I suggest to update them manually. |
Last week someone complained that they don't see the "add study" button. (could be false flag too) Please double-check if this button is shown to all the user types that are allowed to add studies. |
I can not see the add study button on CSIS, meaning I can not play around with studies.
Also, other people (i.e. Anna from WSP) has had problems with adding Solution Offers and Showcases.
It is important that we can start to test the system and produce material.
Best,
Lena
Från: Denis Havlik [mailto:[email protected]]
Skickat: den 19 augusti 2019 15:16
Till: clarity-h2020/docker-drupal
Kopia: Subscribed
Ämne: Re: [clarity-h2020/docker-drupal] Adding new Studies in the CSIS (#83)
Last week someone complained that they don't see the "add study" button. (could be false flag too)
Please double-check if this button is shown to all the user types that are allowed to add studies.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#83?email_source=notifications&email_token=AB2NFIEGJFHRVMP5UMWBYLDQFKMHHA5CNFSM4IGZ5Y32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4S4NIY#issuecomment-522569379>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB2NFIDRASRCKIUSCVK6YQLQFKMHHANCNFSM4IGZ5Y3Q>.
|
See #96 |
The "Create a new Study" button is currently only visible to administrators and until #90 is fully resolved, I wouldn't change that. In the end I guess every authenticated user (so everyone who has an account) should be able to create a new Study. |
Please note that #90 has been resolved. Now we need testers. |
To the best of my knowledge, adding new studies and changing the study type works as designed now. |
I created a new study of type Basic Screening: General by following the create new study link. The result is a study group without navigation tabs: |
Hm. The GL-steps are generated as they should, but you should end up on the https://csis.myclimateservice.eu/study//view/intro. However, the https://csis.myclimateservice.eu/study/28/view/intro doesn't exist, because the alias hasn't been generated. It should be, according to I run the "bulk generate aliases" and now it's OK. But this shouldn't happen. Is this somehow related to "rules" not working occasionally? Now the bulk path generation occasionally fails too? |
Turns out the problem was caused by the For now, I removed the On a related note, I also made the |
I just read the initial entry on "Updating business rules for automatically creating GL-step entitites". This is completely outdated now, it would be good to close this issue and open a new one if necessary. |
You're probably right, but before we close this issue let me just first remove this outdated rules, actions and variables from the system. Looking at the Business rules overview, it's really starting to get confusing. |
why is this still open? |
"Create new Study" button
I added a new button to create a new Study, which is displayed under all tables listing currently available studies (just for now this button is only visible for admins). It shows a simplified form (following the approach we choose for data packages and resources) asking for:
All remaining fields (Country, Sector, data package, ...) can then be filled in later in the appropriate tabs of the study group.
Updating business rules for automatically creating GL-step entitites
Once user creates a new study, Business rules create the necessary 8 GL-steps in the background and prefill them with the needed data. I updated the corresponding rules to include the Map & Table component and the Scenario Analysis app just like it is currently configured for the first study.
1) HC:
Map app: Characterise Hazard initialised React Map (NodeID: 118)
Table app: Characterise Hazard initialised React table (NodeID: 121)
2) HC-LE:
Map app: Hazard Local Effects initialised React Map (116)
Table app: Hazard Local Effects initialised React table (124)
3) EE:
Map app: Evaluate Exposure initialised React Map (114)
Table app: Exposure initialised react table (122)
4) VA:
Map app: Analyse Vulnerability initialised React Map (120)
Table app: Vulnerability initialised React table (126)
Twins-tab hidden
5) RIA:
Scenario Analysis Application: Scenario Analysis (21)
Map app: Assess Risk and Impact initialised React Map (105)
Table app: Risk and Impact initialised React table (106)
Twins-tab hidden
6) AOI:
Table app: Adaptation Options initialised React table (384)
7) AOA:
nothing yet configured
8) AAPI:
nothing yet configured
I believe that's all that's necessary to create a new study with the same functionality as our currently available Study 1. I created a new Study (everyone with an admin account should be able to view this) and only filled out the initial form so far.
@therter, @p-a-s-c-a-l, @fgeyer16: Are there any other fields in the GL-Steps that need to be automatically filled upon creation, which I might have missed?
Note: Keep in mind the current step-by-step wizard implementation. So right after creating a new study, dont be surprised if only the "Hazard Characterization" step is clickable :-)
The text was updated successfully, but these errors were encountered: