-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple the study_variant from the Study Scenarios #100
Comments
What is feasible is to compare in the split-maps either between scenarios with / without adaptation or between scenarios (different combinations of rcp, time_period, event frequency) in general. I think we drop general scenario comparison in favour of baseline vs. adapted comparison since it makes more sense. The important question here is: Do we support different adaptation scenarios or just one? If there is just one adaptation scenario which gets 'overwritten' when adaptation changes, this would make things more easy to implement. In this case, we can completely get rid the 'study_variant' (its always either baseline or adapted) and just have to introduce a property which indicates whether an adaptation scenario is available or not. In the opposite case we need a separate UI control element for selecting an adaptation scenario in addition to the general scenario. For the table it might become more complicated if we need to show not only a mixture of baseline vs adapted. but also of PV and HW. |
I would stick to just one and currently the CSIS is configured to allow only one. I've set it up so that in the future it can be adapted to allow more than just one, but that will require changes in the Drupal Views itself, in the csis_helpers module and in the REST interfaces used by Emikat. We the limited hours I got left, it just doesn't seem very realistic. |
How can I test the new |
I've tried to recalculate study 35 to get an adaptation scenario, but the process is stuck at "14 out of 17 processes". @DenoBeno @humerh ? See also clarity-h2020/emikat#33 (comment) and clarity-h2020/csis-technical-validation#101 |
I've recalculated study 35 and but still there are no adaptation results available. I've created an adaptation strategy but it doesn't seem to get applied. Anything else I need to do get an adaptation scenario? @DenoBeno @fabrisj @humerh @patrickkaleta |
I can update the csis_helpers module on PROD (by pulling the latest version from the git repository). I haven't done so yet, since I wanted to await testing on DEV first. But you're right, it's hard to test this when you're not allowed to trigger Emikat calculations on DEV. @p-a-s-c-a-l are you performing any updates on the Docker containers currently? Because I had troubles accessing DEV and PROD for a while, |
I can see some results for the Adaptation Strategy. Looking at the HC-LE table, I can see results for baseline and for the adapted scenario. |
Thanks @patrickkaleta. Yes, I performed a backup of the database and had to shut it down. Yes, there are now adaptation results available and I can show them on the map: |
Ideally, we can decouple the study_variant from the Study Scenarios, so that it could be possible to show in the Map component the differences of the Study scenario with and without Adaptation options side by side (we already have the split screen with two maps, so we should use it). @therter let's maybe discuss this in a short telco to see how feasible that would be for us in the remaining time.
Originally posted by @patrickkaleta in clarity-h2020/csis#154 (comment)
The text was updated successfully, but these errors were encountered: