Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on the return value of CloudinaryLabs\CloudinaryLaravel\CloudinaryAdapter::readStream() #128

Open
AndikanGabriel opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AndikanGabriel
Copy link

The readStream method of a storage driver is likely expected to return a resource type, but in this package, it is set to bool.

public function readStream(string $path): bool

Upon inspecting its return type, it appears that a boolean value is not returned.

public function readStream(string $path): bool
{
$resource = (array)$this->adminApi()->asset($this->preparePublicId($path));
return fopen($resource['secure_url'], 'rb');
}

I’m not sure if a fix is in the pipeline.

@joshmanders
Copy link
Collaborator

Is this related to #82?

@joshmanders joshmanders added the bug Something isn't working label Sep 6, 2024
@AndikanGabriel
Copy link
Author

@joshmanders no, it is not related to #82

@Jaldev09 Jaldev09 mentioned this issue Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants