Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add top level rawTransformations option to getVideoPlayerOptions #201

Open
colbyfayock opened this issue Sep 25, 2024 · 0 comments

Comments

@colbyfayock
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

A goal of the CldVideoPlayer is to move to a more consistent transformation API similar to the CldImage component.

One first step, based on request, is to create a rawTransformations mechanism which is an escape hatch for people to write whatever transformation they want in the raw URL format.

Usage would appear like:

<CldVideoPlayer rawTransformations={['w_100,h_900,c_fill', 'w_900,h_900,c_pad,b_blue']} />

To make this work, the Cloudinary Video Player exposes a transformation option which itself has a raw_transformation property.

https://github.com/cloudinary/js-url-gen/blob/master/src/types/types.ts#L433

We can utilize this to pass along any raw transformations to that property.

This should be handled from within the getVideoPlayerOptions function to allow all libraries to get this feature support.

Note: as someone could pass in both rawTransformations and transformation.raw_transformations, we should merge the values of those two fields to avoid conflicts and allow them to work together, even though it may not be recommended as such.

Related: nuxt-modules/cloudinary#239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant