diff --git a/lualib-src/sproto/lsproto.c b/lualib-src/sproto/lsproto.c index 602f86e91..af86e389f 100644 --- a/lualib-src/sproto/lsproto.c +++ b/lualib-src/sproto/lsproto.c @@ -19,17 +19,17 @@ */ LUALIB_API void luaL_setfuncs (lua_State *L, const luaL_Reg *l, int nup) { #ifdef luaL_checkversion - luaL_checkversion(L); + luaL_checkversion(L); #endif - luaL_checkstack(L, nup, "too many upvalues"); - for (; l->name != NULL; l++) { /* fill the table with given functions */ - int i; - for (i = 0; i < nup; i++) /* copy upvalues to the top */ - lua_pushvalue(L, -nup); - lua_pushcclosure(L, l->func, nup); /* closure with those upvalues */ - lua_setfield(L, -(nup + 2), l->name); - } - lua_pop(L, nup); /* remove upvalues */ + luaL_checkstack(L, nup, "too many upvalues"); + for (; l->name != NULL; l++) { /* fill the table with given functions */ + int i; + for (i = 0; i < nup; i++) /* copy upvalues to the top */ + lua_pushvalue(L, -nup); + lua_pushcclosure(L, l->func, nup); /* closure with those upvalues */ + lua_setfield(L, -(nup + 2), l->name); + } + lua_pop(L, nup); /* remove upvalues */ } #define luaL_newlibtable(L,l) \ @@ -62,18 +62,20 @@ ldeleteproto(lua_State *L) { static int lquerytype(lua_State *L) { + const char * type_name; struct sproto *sp = lua_touserdata(L,1); + struct sproto_type *st; if (sp == NULL) { return luaL_argerror(L, 1, "Need a sproto object"); } - const char * typename = luaL_checkstring(L,2); - struct sproto_type *st = sproto_type(sp, typename); + type_name = luaL_checkstring(L,2); + st = sproto_type(sp, type_name); if (st) { lua_pushlightuserdata(L, st); return 1; } - return luaL_error(L, "type %s not found", typename); + return luaL_error(L, "type %s not found", type_name); } struct encode_ud { @@ -119,9 +121,10 @@ encode(void *ud, const char *tagname, int type, int index, struct sproto_type *s switch (type) { case SPROTO_TINTEGER: { lua_Integer v = luaL_checkinteger(L, -1); + lua_Integer vh; lua_pop(L,1); // notice: in lua 5.2, lua_Integer maybe 52bit - lua_Integer vh = v >> 31; + vh = v >> 31; if (vh == 0 || vh == -1) { *(uint32_t *)value = (uint32_t)v; return 4; @@ -148,13 +151,14 @@ encode(void *ud, const char *tagname, int type, int index, struct sproto_type *s } case SPROTO_TSTRUCT: { struct encode_ud sub; + int r; sub.L = L; sub.st = st; sub.tbl_index = lua_gettop(L); sub.array_tag = NULL; sub.array_index = 0; sub.deep = self->deep + 1; - int r = sproto_encode(st, value, length, encode, &sub); + r = sproto_encode(st, value, length, encode, &sub); lua_pop(L,1); return r; } @@ -165,6 +169,7 @@ encode(void *ud, const char *tagname, int type, int index, struct sproto_type *s static void * expand_buffer(lua_State *L, int osz, int nsz) { + void *output; do { osz *= 2; } while (osz < nsz); @@ -172,7 +177,7 @@ expand_buffer(lua_State *L, int osz, int nsz) { luaL_error(L, "object is too large (>%d)", ENCODE_MAXSIZE); return NULL; } - void *output = lua_newuserdata(L, osz); + output = lua_newuserdata(L, osz); lua_replace(L, lua_upvalueindex(1)); lua_pushinteger(L, osz); lua_replace(L, lua_upvalueindex(2)); @@ -188,6 +193,7 @@ expand_buffer(lua_State *L, int osz, int nsz) { */ static int lencode(lua_State *L) { + struct encode_ud self; void * buffer = lua_touserdata(L, lua_upvalueindex(1)); int sz = lua_tointeger(L, lua_upvalueindex(2)); @@ -197,7 +203,6 @@ lencode(lua_State *L) { } luaL_checktype(L, 2, LUA_TTABLE); luaL_checkstack(L, ENCODE_DEEPLEVEL + 8, NULL); - struct encode_ud self; self.L = L; self.st = st; self.tbl_index = 2; @@ -261,15 +266,16 @@ decode(void *ud, const char *tagname, int type, int index, struct sproto_type *s break; } case SPROTO_TSTRUCT: { - lua_newtable(L); struct decode_ud sub; + int r; + lua_newtable(L); sub.L = L; sub.result_index = lua_gettop(L); sub.deep = self->deep + 1; sub.array_index = 0; sub.array_tag = NULL; - int r = sproto_decode(st, value, length, decode, &sub); + r = sproto_decode(st, value, length, decode, &sub); if (r < 0 || r != length) return r; lua_settop(L, sub.result_index); @@ -312,22 +318,25 @@ getbuffer(lua_State *L, int index, size_t *sz) { static int ldecode(lua_State *L) { struct sproto_type * st = lua_touserdata(L, 1); + const void * buffer; + struct decode_ud self; + size_t sz; + int r; if (st == NULL) { return luaL_argerror(L, 1, "Need a sproto_type object"); } - size_t sz=0; - const void * buffer = getbuffer(L, 2, &sz); + sz = 0; + buffer = getbuffer(L, 2, &sz); if (!lua_istable(L, -1)) { lua_newtable(L); } luaL_checkstack(L, ENCODE_DEEPLEVEL*2 + 8, NULL); - struct decode_ud self; self.L = L; self.result_index = lua_gettop(L); self.array_index = 0; self.array_tag = NULL; self.deep = 0; - int r = sproto_decode(st, buffer, (int)sz, decode, &self); + r = sproto_decode(st, buffer, (int)sz, decode, &self); if (r < 0) { return luaL_error(L, "decode error"); } @@ -359,11 +368,12 @@ lpack(lua_State *L) { // the worst-case space overhead of packing is 2 bytes per 2 KiB of input (256 words = 2KiB). size_t maxsz = (sz + 2047) / 2048 * 2 + sz; void * output = lua_touserdata(L, lua_upvalueindex(1)); + int bytes; int osz = lua_tointeger(L, lua_upvalueindex(2)); if (osz < maxsz) { output = expand_buffer(L, osz, maxsz); } - int bytes = sproto_pack(buffer, sz, output, maxsz); + bytes = sproto_pack(buffer, sz, output, maxsz); if (bytes > maxsz) { return luaL_error(L, "packing error, return size = %d", bytes); } @@ -402,14 +412,18 @@ pushfunction_withbuffer(lua_State *L, const char * name, lua_CFunction func) { static int lprotocol(lua_State *L) { struct sproto * sp = lua_touserdata(L, 1); + struct sproto_type * request; + struct sproto_type * response; + int t; + int tag; if (sp == NULL) { return luaL_argerror(L, 1, "Need a sproto_type object"); } - int t = lua_type(L,2); - int tag; + t = lua_type(L,2); if (t == LUA_TNUMBER) { + const char * name; tag = lua_tointeger(L, 2); - const char * name = sproto_protoname(sp, tag); + name = sproto_protoname(sp, tag); if (name == NULL) return 0; lua_pushstring(L, name); @@ -420,13 +434,13 @@ lprotocol(lua_State *L) { return 0; lua_pushinteger(L, tag); } - struct sproto_type * request = sproto_protoquery(sp, tag, SPROTO_REQUEST); + request = sproto_protoquery(sp, tag, SPROTO_REQUEST); if (request == NULL) { lua_pushnil(L); } else { lua_pushlightuserdata(L, request); } - struct sproto_type * response = sproto_protoquery(sp, tag, SPROTO_RESPONSE); + response = sproto_protoquery(sp, tag, SPROTO_RESPONSE); if (response == NULL) { lua_pushnil(L); } else { diff --git a/lualib-src/sproto/sproto.c b/lualib-src/sproto/sproto.c index ca43cd9b5..24d364922 100644 --- a/lualib-src/sproto/sproto.c +++ b/lualib-src/sproto/sproto.c @@ -119,8 +119,8 @@ todword(const uint8_t *p) { static int count_array(const uint8_t * stream) { uint32_t length = todword(stream); - stream += SIZEOF_LENGTH; int n = 0; + stream += SIZEOF_LENGTH; while (length > 0) { uint32_t nsz; if (length < SIZEOF_LENGTH) @@ -180,6 +180,10 @@ static const uint8_t * import_field(struct sproto *s, struct field *f, const uint8_t * stream) { uint32_t sz; const uint8_t * result; + int fn; + int i; + int array = 0; + int tag = -1; f->tag = -1; f->type = -1; f->name = NULL; @@ -188,13 +192,10 @@ import_field(struct sproto *s, struct field *f, const uint8_t * stream) { sz = todword(stream); stream += SIZEOF_LENGTH; result = stream + sz; - int fn = struct_field(stream, sz); + fn = struct_field(stream, sz); if (fn < 0) return NULL; stream += SIZEOF_HEADER; - int i; - int array = 0; - int tag = -1; for (i=0;iname = import_string(s, stream + fn * SIZEOF_FIELD); @@ -213,12 +214,12 @@ import_field(struct sproto *s, struct field *f, const uint8_t * stream) { return NULL; value = value/2 - 1; switch(tag) { - case 1: // buildin + case 1: // buildin if (value >= SPROTO_TSTRUCT) return NULL; // invalid buildin type f->type = value; break; - case 2: // type index + case 2: // type index if (value >= s->type_n) return NULL; // invalid type index if (f->type >= 0) @@ -226,10 +227,10 @@ import_field(struct sproto *s, struct field *f, const uint8_t * stream) { f->type = SPROTO_TSTRUCT; f->st = &s->type[value]; break; - case 3: // tag + case 3: // tag f->tag = value; break; - case 4: // array + case 4: // array if (value) array = SPROTO_TARRAY; break; @@ -248,10 +249,10 @@ import_field(struct sproto *s, struct field *f, const uint8_t * stream) { .type { .field { name 0 : string - buildin 1 : integer + buildin 1 : integer type 2 : integer - tag 3 : integer - array 4 : boolean + tag 3 : integer + array 4 : boolean } name 0 : string fields 1 : *field @@ -259,11 +260,16 @@ import_field(struct sproto *s, struct field *f, const uint8_t * stream) { */ static const uint8_t * import_type(struct sproto *s, struct sproto_type *t, const uint8_t * stream) { + const uint8_t * result; uint32_t sz = todword(stream); int i; + int fn; + int n; + int maxn; + int last; stream += SIZEOF_LENGTH; - const uint8_t * result = stream + sz; - int fn = struct_field(stream, sz); + result = stream + sz; + fn = struct_field(stream, sz); if (fn <= 0 || fn > 2) return NULL; for (i=0;in = n; t->f = pool_alloc(&s->memory, sizeof(struct field) * n); for (i=0;if[i]; stream = import_field(s, f, stream); if (stream == NULL) return NULL; - int tag = f->tag; + tag = f->tag; if (tag < last) return NULL; // tag must in ascending order if (tag > last+1) { @@ -312,24 +319,27 @@ import_type(struct sproto *s, struct sproto_type *t, const uint8_t * stream) { /* .protocol { name 0 : string - tag 1 : integer - request 2 : integer + tag 1 : integer + request 2 : integer response 3 : integer } */ static const uint8_t * import_protocol(struct sproto *s, struct protocol *p, const uint8_t * stream) { + const uint8_t * result; uint32_t sz = todword(stream); + int fn; + int i; + int tag; stream += SIZEOF_LENGTH; - const uint8_t * result = stream + sz; - int fn = struct_field(stream, sz); + result = stream + sz; + fn = struct_field(stream, sz); stream += SIZEOF_HEADER; p->name = NULL; p->tag = -1; p->p[SPROTO_REQUEST] = NULL; p->p[SPROTO_RESPONSE] = NULL; - int i; - int tag = 0; + tag = 0; for (i=0;iname = import_string(s, stream + SIZEOF_FIELD *fn); break; - case 1: // tag + case 1: // tag if (value < 0) { return NULL; } p->tag = value; break; - case 2: // request + case 2: // request if (value < 0 || value>=s->type_n) return NULL; p->p[SPROTO_REQUEST] = &s->type[value]; break; - case 3: // response + case 3: // response if (value < 0 || value>=s->type_n) return NULL; p->p[SPROTO_RESPONSE] = &s->type[value]; @@ -374,22 +384,23 @@ import_protocol(struct sproto *s, struct protocol *p, const uint8_t * stream) { static struct sproto * create_from_bundle(struct sproto *s, const uint8_t * stream, size_t sz) { + const uint8_t * content; + const uint8_t * typedata = NULL; + const uint8_t * protocoldata = NULL; int fn = struct_field(stream, sz); + int i; if (fn < 0) return NULL; stream += SIZEOF_HEADER; + content = stream + fn*SIZEOF_FIELD; - const uint8_t * content = stream + fn*SIZEOF_FIELD; - const uint8_t * typedata = NULL; - const uint8_t * protocoldata = NULL; - - int i; for (i=0;itype_n); - int i,j; for (i=0;itype_n;i++) { struct sproto_type *t = &s->type[i]; printf("%s\n", t->name); for (j=0;jn;j++) { char array[2] = { 0, 0 }; - const char * typename = NULL; + const char * type_name = NULL; struct field *f = &t->f[j]; if (f->type & SPROTO_TARRAY) { array[0] = '*'; } else { array[0] = 0; } - int t = f->type & ~SPROTO_TARRAY; - if (t == SPROTO_TSTRUCT) { - typename = f->st->name; - } else { - assert(ttype & ~SPROTO_TARRAY; + if (t == SPROTO_TSTRUCT) { + type_name = f->st->name; + } else { + assert(tname, f->tag, array, typename); + printf("\t%s (%d) %s%s\n", f->name, f->tag, array, type_name); } } printf("=== %d protocol ===\n", s->protocol_n); @@ -518,10 +531,11 @@ query_proto(struct sproto *sp, int tag) { struct sproto_type * sproto_protoquery(struct sproto *sp, int proto, int what) { + struct protocol * p; if (what <0 || what >1) { return NULL; } - struct protocol * p = query_proto(sp, proto); + p = query_proto(sp, proto); if (p) { return p->p[what]; } @@ -555,13 +569,15 @@ sproto_name(struct sproto_type * st) { static struct field * findtag(struct sproto_type *st, int tag) { + int begin, end; if (st->base >=0 ) { tag -= st->base; if (tag < 0 || tag >= st->n) return NULL; return &st->f[tag]; } - int begin = 0, end = st->n; + begin = 0; + end = st->n; while (begin < end) { int mid = (begin+end)/2; struct field *f = &st->f[mid]; @@ -580,7 +596,7 @@ findtag(struct sproto_type *st, int tag) { // encode & decode // sproto_callback(void *ud, int tag, int type, struct sproto_type *, void *value, int length) -// return size, -1 means error +// return size, -1 means error static inline int fill_size(uint8_t * data, int sz) { @@ -623,18 +639,20 @@ encode_uint64(uint64_t v, uint8_t * data, int size) { static int encode_string(sproto_callback cb, void *ud, struct field *f, uint8_t *data, int size) { + int sz; if (size < SIZEOF_LENGTH) return -1; - int sz = cb(ud, f->name, SPROTO_TSTRING, 0, NULL, data+SIZEOF_LENGTH, size-SIZEOF_LENGTH); + sz = cb(ud, f->name, SPROTO_TSTRING, 0, NULL, data+SIZEOF_LENGTH, size-SIZEOF_LENGTH); return fill_size(data, sz); } static int encode_struct(sproto_callback cb, void *ud, struct field *f, uint8_t *data, int size) { + int sz; if (size < SIZEOF_LENGTH) { return -1; } - int sz = cb(ud, f->name, SPROTO_TSTRUCT, 0, f->st, data+SIZEOF_LENGTH, size-SIZEOF_LENGTH); + sz = cb(ud, f->name, SPROTO_TSTRUCT, 0, f->st, data+SIZEOF_LENGTH, size-SIZEOF_LENGTH); return fill_size(data, sz); } @@ -656,18 +674,21 @@ uint32_to_uint64(int negative, uint8_t *buffer) { static uint8_t * encode_integer_array(sproto_callback cb, void *ud, struct field *f, uint8_t *buffer, int size) { uint8_t * header = buffer; + int intlen; + int index; if (size < 1) return NULL; buffer++; size--; - int intlen = sizeof(uint32_t); - int index = 1; + intlen = sizeof(uint32_t); + index = 1; for (;;) { + int sz; union { uint64_t u64; uint32_t u32; } u; - int sz = cb(ud, f->name, SPROTO_TINTEGER, index, f->st, &u, sizeof(u)); + sz = cb(ud, f->name, SPROTO_TINTEGER, index, f->st, &u, sizeof(u)); if (sz < 0) return NULL; if (sz == 0) @@ -685,24 +706,26 @@ encode_integer_array(sproto_callback cb, void *ud, struct field *f, uint8_t *buf uint32_to_uint64(v & 0x80000000, buffer); } } else { + uint64_t v; if (sz != sizeof(uint64_t)) return NULL; if (intlen == sizeof(uint32_t)) { + int i; // rearrange size -= (index-1) * sizeof(uint32_t); if (size < sizeof(uint64_t)) return NULL; buffer += (index-1) * sizeof(uint32_t); - int i; for (i=index-2;i>=0;i--) { + int negative; memcpy(header+1+i*sizeof(uint64_t), header+1+i*sizeof(uint32_t), sizeof(uint32_t)); - int negative = header[1+i*sizeof(uint64_t)+3] & 0x80; + negative = header[1+i*sizeof(uint64_t)+3] & 0x80; uint32_to_uint64(negative, header+1+i*sizeof(uint64_t)); } intlen = sizeof(uint64_t); } - uint64_t v = u.u64; + v = u.u64; buffer[0] = v & 0xff; buffer[1] = (v >> 8) & 0xff; buffer[2] = (v >> 16) & 0xff; @@ -727,12 +750,16 @@ encode_integer_array(sproto_callback cb, void *ud, struct field *f, uint8_t *buf static int encode_array(sproto_callback cb, void *ud, struct field *f, uint8_t *data, int size) { + uint8_t * buffer; + int index; + int type; + int sz; if (size < SIZEOF_LENGTH) return -1; size -= SIZEOF_LENGTH; - int index = 1; - uint8_t * buffer = data + SIZEOF_LENGTH; - int type = f->type & ~SPROTO_TARRAY; + index = 1; + buffer = data + SIZEOF_LENGTH; + type = f->type & ~SPROTO_TARRAY; switch (type) { case SPROTO_TINTEGER: buffer = encode_integer_array(cb,ud,f,buffer,size); @@ -757,10 +784,11 @@ encode_array(sproto_callback cb, void *ud, struct field *f, uint8_t *data, int s break; default: for (;;) { + int sz; if (size < SIZEOF_LENGTH) return -1; size -= SIZEOF_LENGTH; - int sz = cb(ud, f->name, type, index, f->st, buffer+SIZEOF_LENGTH, size); + sz = cb(ud, f->name, type, index, f->st, buffer+SIZEOF_LENGTH, size); if (sz < 0) return -1; if (sz == 0) @@ -772,7 +800,7 @@ encode_array(sproto_callback cb, void *ud, struct field *f, uint8_t *data, int s } break; } - int sz = buffer - (data + SIZEOF_LENGTH); + sz = buffer - (data + SIZEOF_LENGTH); if (sz == 0) return 0; return fill_size(data, sz); @@ -783,13 +811,16 @@ sproto_encode(struct sproto_type *st, void * buffer, int size, sproto_callback c uint8_t * header = buffer; uint8_t * data; int header_sz = SIZEOF_HEADER + st->maxn * SIZEOF_FIELD; + int i; + int index; + int lasttag; + int datasz; if (size < header_sz) return -1; data = header + header_sz; size -= header_sz; - int i; - int index = 0; - int lasttag = -1; + index = 0; + lasttag = -1; for (i=0;in;i++) { struct field *f = &st->f[i]; int type = f->type; @@ -813,7 +844,7 @@ sproto_encode(struct sproto_type *st, void * buffer, int size, sproto_callback c if (sz == sizeof(uint32_t)) { if (u.u32 < 0x7fff) { value = (u.u32+1) * 2; - sz = 2; // sz can be any number > 0 + sz = 2; // sz can be any number > 0 } else { sz = encode_integer(u.u32, data, size); } @@ -837,12 +868,14 @@ sproto_encode(struct sproto_type *st, void * buffer, int size, sproto_callback c if (sz < 0) return -1; if (sz > 0) { + uint8_t * record; + int tag; if (value == 0) { data += sz; size -= sz; } - uint8_t * record = header+SIZEOF_HEADER+SIZEOF_FIELD*index; - int tag = f->tag - lasttag - 1; + record = header+SIZEOF_HEADER+SIZEOF_FIELD*index; + tag = f->tag - lasttag - 1; if (tag > 0) { // skip tag tag = (tag - 1) * 2 + 1; @@ -862,7 +895,7 @@ sproto_encode(struct sproto_type *st, void * buffer, int size, sproto_callback c header[0] = index & 0xff; header[1] = (index >> 8) & 0xff; - int datasz = data - (header + header_sz); + datasz = data - (header + header_sz); data = header + header_sz; if (index != st->maxn) { memmove(header + SIZEOF_HEADER + index * SIZEOF_FIELD, data, datasz); @@ -909,9 +942,10 @@ decode_array(sproto_callback cb, void *ud, struct field *f, uint8_t * stream) { stream += SIZEOF_LENGTH; switch (type) { case SPROTO_TINTEGER: { + int len; if (sz < 1) return -1; - int len = *stream; + len = *stream; ++stream; --sz; if (len == sizeof(uint32_t)) { @@ -956,6 +990,8 @@ sproto_decode(struct sproto_type *st, const void * data, int size, sproto_callba uint8_t * stream; uint8_t * datastream; int fn; + int i; + int tag; if (size < SIZEOF_HEADER) return -1; stream = (void *)data; @@ -967,17 +1003,18 @@ sproto_decode(struct sproto_type *st, const void * data, int size, sproto_callba datastream = stream + fn * SIZEOF_FIELD; size -= fn * SIZEOF_FIELD ; - int i; - int tag = -1; + tag = -1; for (i=0;i