Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Memory/CPU Settings are also used for task CPU/Memory - breaking multiple containers #63

Open
decoded4620 opened this issue Aug 7, 2024 · 0 comments

Comments

@decoded4620
Copy link

decoded4620 commented Aug 7, 2024

The current version 1.0.36 uses the input container_cpu and container_memory both for the primary Container Definition (which is required to be configured) as well as the ECS Task definition. This creates a problem with adding more containers using additional_containers. You cannot specify cpu / memory settings for those additional containers, or the sum of all cpu / all memory will always be greater than the task cpu / memory.

Thus when launching tasks configured this way, the additional container can only have 0 memory / 0 cpu. This is a simple fix, in which we can add task_memory and task_cpu variables to the module, and ensure that these are used for the container. As long as the primary container definition and any additional containers have a sum of cpu / memory that is less than the total, both containers will be able to start.

This also means that the multiple_containers example provided with this version does NOT work as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant