Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for firecracker v1.0.0 #20

Open
ghost opened this issue Apr 19, 2022 · 2 comments
Open

Add support for firecracker v1.0.0 #20

ghost opened this issue Apr 19, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Apr 19, 2022

Hi there,
Currently the firecracker-task-driver can't use the v1.0.0 firecracker binary because of a breaking change in firecracker. Specifically the ht_enabled field was renamed to smt and is now optional per https://github.com/firecracker-microvm/firecracker/releases/tag/v1.0.0

ghost pushed a commit to grapl-security/grapl that referenced this issue Apr 19, 2022
The nomad firecracker plugin currently breaks on the 1.0.0 firecracker
binary. Specifically, the ht_enabled field has been renamed and is now
optional. See cneira/firecracker-task-driver#20
for details
ghost pushed a commit to grapl-security/grapl that referenced this issue Apr 19, 2022
The nomad firecracker plugin currently breaks on the 1.0.0 firecracker
binary. Specifically, the ht_enabled field has been renamed and is now
optional. See cneira/firecracker-task-driver#20
for details
@cneira cneira added enhancement New feature or request help wanted Extra attention is needed labels Apr 20, 2022
ghost pushed a commit to grapl-security/grapl that referenced this issue Apr 20, 2022
The nomad firecracker plugin currently breaks on the 1.0.0 firecracker
binary. Specifically, the ht_enabled field has been renamed and is now
optional. See cneira/firecracker-task-driver#20
for details
@cneira
Copy link
Owner

cneira commented May 24, 2022

Hi there,
Currently the firecracker-task-driver can't use the v1.0.0 firecracker binary because of a breaking change in firecracker. Specifically the ht_enabled field was renamed to smt and is now optional per https://github.com/firecracker-microvm/firecracker/releases/tag/v1.0.0

Thanks a lot for letting me know, I'll start working on this as I have a spare machine now to work at home.

@cneira
Copy link
Owner

cneira commented Aug 3, 2022

This is going to take a lot of more time than I thought, I work on this on my free time at nights after work so I'll try to return this issue I hope in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant