Add example test for forwards compat of custom setting #17524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
memsharded
reviewed
Dec 30, 2024
| available_libc_versions = conanfile.settings.libc_version.possible_values() | ||
| ret = [] | ||
| for possible_libc_version in available_libc_versions: | ||
| if Version(possible_libc_version) >= Version(libc_version): |
There was a problem hiding this comment.
this is the other way round. Packages created with an older libc can be used with the current libc_version. So better <=
| tc.save({ | ||
| "dep/conanfile.py": GenConanfile("dep", "1.0") | ||
| .with_settings("compiler", "libc_version"), | ||
| "conanfile.py": GenConanfile("app", "1.0") |
There was a problem hiding this comment.
Can be dropped, and tested with conan install --requires=xxxx
memsharded
reviewed
Jan 7, 2025
AbrilRBS
commented
Jan 13, 2025
| @@ -706,3 +709,83 @@ def validate_build(self): | |||
| pkga = liba["packages"][0][pkg_index] | |||
| assert pkga["info"]["compatibility_delta"] == {"settings": [["compiler.cppstd", "14"]]} | |||
| assert pkga["build_args"] == "--requires=liba/0.1 --build=compatible:liba/0.1" | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(platform.system() != "Windows", reason="MSVC combination requires Windows profile, but the basic idea works everywhere") | |||
There was a problem hiding this comment.
I added this to show that the combination logic is sound, but for the docs we'll drop the msvc variability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
As part of the answer for #17523, I thought that a test that reflects the desired behaviour would be great to have, as a reference point for the future
Update: Now seeing the linked issue, OP was not exactly following this approach, but I think it's still worth it to add something like this