Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLabSourceAcl does not URL-encode the $filepath #89

Open
sverrehu opened this issue Sep 1, 2020 · 0 comments
Open

GitLabSourceAcl does not URL-encode the $filepath #89

sverrehu opened this issue Sep 1, 2020 · 0 comments

Comments

@sverrehu
Copy link

sverrehu commented Sep 1, 2020

See GitLab API doc: https://docs.gitlab.com/ee/api/#file-path-branches-and-tags-name-encoding

If a file path, branch or tag contains a /, make sure it is URL-encoded. For example, / is represented by %2F:

GET /api/v4/projects/1/repository/files/src%2FREADME.md?ref=master

GitLabSourceAcl.scala includes the $filepath from SOURCE_GITLAB_FILEPATH verbatim, leaving it to the person setting up Kafka Security Manager to know the API details of GitLab. I think the one doing the API call should handle the API requirements.

I do not speak Scala, so I cannot provide a patch. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant