Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide env.uriScheme to CCloud connections' ccloud_config #886

Open
shouples opened this issue Jan 9, 2025 · 0 comments
Open

Provide env.uriScheme to CCloud connections' ccloud_config #886

shouples opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels
CCloud auth Issue related to authentication to Confluent Cloud through the extension enhancement New feature or request

Comments

@shouples
Copy link
Contributor

shouples commented Jan 9, 2025

Requires confluentinc/ide-sidecar#288 to be complete first.

We will need to start passing the URI scheme (vscode, vscode-insiders, etc) to CCloud connections via the spec.ccloud_config so CCloud auth redirects will point at the product/distribution that originally created the connection. This also means we will need to make the (currently static) CCloud connection ID also use the URI scheme in the event a user wants to sign in with the extension across multiple products.

vscode/src/constants.ts

Lines 41 to 49 in 40816c4

/** Single CCloud connection spec to be used with the sidecar Connections API. */
export const CCLOUD_CONNECTION_SPEC: ConnectionSpec = {
id: "vscode-confluent-cloud-connection",
name: "Confluent Cloud",
type: "CCLOUD",
};
// these two avoid the need to use `CCLOUD_CONNECTION_SPEC.id!` or `CCLOUD_CONNECTION_SPEC.name!`
// everywhere in the codebase
export const CCLOUD_CONNECTION_ID = CCLOUD_CONNECTION_SPEC.id! as ConnectionId;

@shouples shouples added enhancement New feature or request CCloud auth Issue related to authentication to Confluent Cloud through the extension labels Jan 9, 2025
@shouples shouples self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCloud auth Issue related to authentication to Confluent Cloud through the extension enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant