Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core #112

Open
hackerncoder opened this issue Jan 8, 2021 · 2 comments
Open

Update core #112

hackerncoder opened this issue Jan 8, 2021 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@hackerncoder
Copy link
Collaborator

The addon works great and does what it needs to do. However the core was forked 3 years ago, and in this time contain-facebook has gotten more than a 1000 commits, which we haven't added into our fork.

I was thinking about creating updating and keeping somewhat up to date with contain-facebook, or maybe creating a different addon that would keep up to date. I just wanted others input on this before I started, so that I don't waste my time if it is a bad idea.

@hackerncoder hackerncoder added enhancement New feature or request question Further information is requested labels Jan 8, 2021
@Perflyst
Copy link
Collaborator

Perflyst commented Jan 9, 2021

I haven't really followed the changes there. If there are useful changes that can make this addon better, we should of course make use of them

@situplastik
Copy link
Contributor

Checking contain-facebook, the only differece is it has a icon on the toolbar with an explanation and the "add domain into facebook container". contain-google have many other options but inside the preferences tab. Maybe internally works better or have some bugs fixed, I don't know...

In my opinion, the only upgrade that could be interesting would be to import the toolbar and put all preferences inside. But for my, the contain-google as now is enought.

@hackerncoder , let me know if you need help on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Development

No branches or pull requests

3 participants