Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI Image Based Updates download much more data than delta packages require - quay.io Kinoite Beta #4279

Closed
ke151 opened this issue Jan 27, 2023 · 1 comment

Comments

@ke151
Copy link

ke151 commented Jan 27, 2023

Host system details

Provide the output of rpm-ostree status.

State: idle
Deployments:
● ostree-unverified-registry:quay.io/fedora-ostree-desktops/kinoite-beta
                   Digest: sha256:d56377da6a61b40a0f90d3a24ead2c077a8fa2adedd89779577aa2d6e2735a05
                  Version: 37.20230126.0 (2023-01-26T18:11:47Z)
      RemovedBasePackages: firefox firefox-langpacks 109.0-1.fc37
                           plasma-discover-rpm-ostree plasma-discover plasma-discover-notifier plasma-discover-flatpak 5.26.90-3.fc37
          LayeredPackages: distrobox

  ostree-unverified-registry:quay.io/fedora-ostree-desktops/kinoite-beta
                   Digest: sha256:82453cb5a8a59c4f9270b87b54f9b6b733a3a28d64fd03d02607d73127522c3c
                  Version: 37.20230125.0 (2023-01-26T02:10:39Z)
      RemovedBasePackages: firefox firefox-langpacks 109.0-1.fc37
                           plasma-discover-rpm-ostree plasma-discover plasma-discover-notifier plasma-discover-flatpak 5.26.90-3.fc37
          LayeredPackages: distrobox

Expected vs actual behavior

$ rpm-ostree upgrade
Pulling manifest: ostree-unverified-image:docker://quay.io/fedora-ostree-desktops/kinoite-beta
Importing: ostree-unverified-image:docker://quay.io/fedora-ostree-desktops/kinoite-beta (digest: sha256:d56377da6a61b40a0f90d3a24ead2c077a8fa2adedd89779577aa2d6e2735a05)
ostree chunk layers stored: 60 needed: 5 (893.0 MB)
Fetching ostree chunk sha256:6e6c18e97a5d (41.3 MB)
Fetched ostree chunk sha256:6e6c18e97a5d
Fetching ostree chunk sha256:84f21a256a17 (78.5 MB)
Fetched ostree chunk sha256:84f21a256a17
Fetching ostree chunk sha256:a053221086ee (17.9 MB)
Fetched ostree chunk sha256:a053221086ee
Fetching ostree chunk sha256:45ce6e8ce93e (747.9 MB)
Fetched ostree chunk sha256:45ce6e8ce93e
Fetching ostree chunk sha256:01982203452e (7.4 MB)
Fetched ostree chunk sha256:01982203452e
Checking out tree 6447864... done

The result of all this is a delta of just a few packages:

Upgraded:
  bind-libs 32:9.18.8-1.fc37 -> 32:9.18.10-1.fc37
  bind-license 32:9.18.8-1.fc37 -> 32:9.18.10-1.fc37
  bind-utils 32:9.18.8-1.fc37 -> 32:9.18.10-1.fc37
  ca-certificates 2022.2.54-5.fc37 -> 2023.2.60-1.0.fc37
  cmake-filesystem 3.25.1-2.fc37 -> 3.25.2-1.fc37
  libpcap 14:1.10.2-1.fc37 -> 14:1.10.3-1.fc37
  qemu-guest-agent 2:7.0.0-12.fc37 -> 2:7.0.0-13.fc37
  rpm-ostree 2022.19-2.fc37 -> 2023.1-1.fc37
  rpm-ostree-libs 2022.19-2.fc37 -> 2023.1-1.fc37

Expected:

rpm-ostree download less data for new image.

Steps to reproduce it

Going between the above listed commits in the ostree-unverified-registry:quay.io/fedora-ostree-desktops/kinoite-beta seems to have this effect (Have not tested other builds exhaustively). It's especially noticeable like this example where the number of changed packages is fairly small.

NOTE: I don't know much about the underlying OCI image structure; it's very possible this behavior is just due to the way the images were built (massive blob different between the two). Please feel free to close the issue if that seems to be the case.

Would you like to work on the issue?

Sorry, I will not be able to work on the issue (if there is one).

@cgwalters
Copy link
Member

Hi, yep; we're working on it! This is a dup of #4012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants