Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aws/aws-sdk-go dependency in dynamodb ring #6487

Open
friedrichg opened this issue Jan 7, 2025 · 0 comments
Open

Remove aws/aws-sdk-go dependency in dynamodb ring #6487

friedrichg opened this issue Jan 7, 2025 · 0 comments
Labels
component/ring type/chore Something that needs to be done; not a bug or a feature

Comments

@friedrichg
Copy link
Member

Describe the bug
Update aws/aws-sdk-go to aws/aws-sdk-go-v2 in

cortex/pkg/ring/kv/dynamodb/dynamodb.go

Line 10 in c2c4827

"github.com/aws/aws-sdk-go/aws"

and remove dependency in go.mod and go.sum

The old sdk is in maintenance mode https://github.com/aws/aws-sdk-go?tab=readme-ov-file#warning-this-sdk-is-in-maintenance-mode
@friedrichg friedrichg added type/chore Something that needs to be done; not a bug or a feature component/ring labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ring type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@friedrichg