Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS support #14

Open
dcbaker opened this issue Feb 28, 2024 · 4 comments
Open

MacOS support #14

dcbaker opened this issue Feb 28, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dcbaker
Copy link
Collaborator

dcbaker commented Feb 28, 2024

All current work has been done on Linux. MacOS support shouldn't be too hard, given that it is still a Unix-like OS.

Although we could likely use homebrew to install the dependencies, I think it would be better to not do that, since that will give us a test that Meson builds all of it's own dependencies without a chance of accidentally getting headers from /usr/include, which helps to catch cases were headers are needed but explicitly given

@dcbaker dcbaker added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 28, 2024
@ChrisThrasher
Copy link

I was able to build this on macOS and run the tests successfully without modification. What else is required to fully support macOS?

@dcbaker
Copy link
Collaborator Author

dcbaker commented Mar 13, 2024

A CI job would be nice.

#31 doesn't implement the Windows or MacOS paths, just the *nix ones, so that would need to be added. I'm starting to rebase that now

@bretbrownjr
Copy link
Collaborator

We'll need to get someone to sponsor CI or we'll have to be judicious about our CI fan-out on every commit, but I agree that we need automated testing.

Seems like running a weekly job for every supported configuration is the minimum requirement.

@dcbaker
Copy link
Collaborator Author

dcbaker commented Mar 13, 2024

I do have #52, which should help with CI usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants