Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cyclical requires #30

Open
dcbaker opened this issue Mar 4, 2024 · 3 comments
Open

Handle cyclical requires #30

dcbaker opened this issue Mar 4, 2024 · 3 comments
Assignees

Comments

@dcbaker
Copy link
Collaborator

dcbaker commented Mar 4, 2024

By either ignoring them as an invalid solution, or returning an appropriate error when there is no valid solution

@dcbaker dcbaker self-assigned this Mar 4, 2024
@bretbrownjr
Copy link
Collaborator

We should allow modelling of cyclical graphs. It's a real situation that becomes an adoption hurdle when it happens. In particular, codebases that are messy shouldn't be forced to completely get their acts together before adopting CPS or any tools that require well formed CPS in the distant future.

It's probably OK to make support for cycles an explicitly opt-in feature though.

@dcbaker
Copy link
Collaborator Author

dcbaker commented Mar 4, 2024

I looked at what pkgconf did again, I thought that it was aborting on cycles, but it breaks the cycle. I think it would be worth doing what pkgconf does. But we need to do anything other than what we do now, which is recurse until the stack overflows

@bretbrownjr
Copy link
Collaborator

It's a leetcode not-a-big-deal problem to walk a cyclical graph, so I'm sure we can manage. Someone write this up like it's leetcode, mark it help-wanted, and I'm sure someone will pick it up in due time.

I don't know if we need it for an MVP, to be clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants