New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get version out of header files #90

Open

lunacd opened this issue Jun 26, 2024 · 1 comment

Labels

enhancement good first issue help wanted

Contributor

lunacd commented Jun 26, 2024 •

edited by bretbrownjr

Loading

I'm not a huge fan of putting version information in header files as it pessimizes build caching in general, though keeping feature parity across CMake and meson is more important for this PR to land. A followon PR to consider another approach would be interesting to me. Eventually.

Originally posted by @bretbrownjr in #82 (comment)

bretbrownjr added enhancement help wanted good first issue labels

Collaborator

bretbrownjr commented Sep 27, 2024

Other options:

Version info in a config file
Version info hardcoded, but in a cpp file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment