Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Typescript Code #53

Open
crookedneighbor opened this issue May 29, 2020 · 1 comment
Open

Clean up Typescript Code #53

crookedneighbor opened this issue May 29, 2020 · 1 comment
Labels
Milestone

Comments

@crookedneighbor
Copy link
Owner

The initial conversion to Typescript is complete, but there are a bunch of TODOs and uses of any and Function that need to be addressed.

And I'm sure that there are other things in the repo that could be more typescripty.

@crookedneighbor crookedneighbor changed the title Cleanup Typescript Code Clean up Typescript Code May 29, 2020
@crookedneighbor
Copy link
Owner Author

The only thing left to do on this will require some work in scryfall-client to expose the Model types as first class exports and possibly PR to framebus to better handle the types for the callback handlers.

@crookedneighbor crookedneighbor added this to the v1.0.0 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant