Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cultureamp/example-go-buildkite-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.0
Choose a base ref
...
head repository: cultureamp/example-go-buildkite-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 7 commits
  • 16 files changed
  • 5 contributors

Commits on Oct 17, 2023

  1. docs: notes on releasing

    tomwwright committed Oct 17, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    40983c3 View commit details

Commits on Dec 3, 2024

  1. chore: tweaks following end-to-end verification (#2)

    * chore: releases may be locally tested, avoid committing these
    
    * docs: BK plugin env vars are named after the plugin
    
    * chore(goreleaser): update schema to v2
    
    * refactor: plugin linting is the more accurate description of workflow
    
    * fix: dangling ecr-scan-results plugin test config
    therealvio authored Dec 3, 2024
    Copy the full SHA
    e82c2cf View commit details

Commits on Dec 4, 2024

  1. chore(deps): add renovate.json5 (#4)

    Co-authored-by: cultureamp-renovate[bot] <89962466+cultureamp-renovate[bot]@users.noreply.github.com>
    cultureamp-renovate[bot] authored Dec 4, 2024
    Copy the full SHA
    8e6a47d View commit details
  2. test: match error string when the environment variable is missing (#3)

    * chore: envConfig overrides Buildkite plugin prefixing
    
    * test: match the error string when the env var is missing
    
    This change fixes a test that returns a false-positive. This occurred
    because previously the check was for *any* error, not specifically
    if the required environment variable was missing. This is fixed by
    checking the error message, rather than naively checking for any error.
    therealvio authored Dec 4, 2024
    Copy the full SHA
    b05c8b4 View commit details

Commits on Dec 5, 2024

  1. ci: update linting config (#1)

    * ci: update linting config
    
    These changes have been copied from cultureamp/ecs-task-runner-buildkite-plugin#3
    
    * ci: disable gci linter
    
    This linter isn't required because Go includes built-in functionality
    for sorting import statements.
    ctgardner authored Dec 5, 2024
    Copy the full SHA
    95f23d2 View commit details

Commits on Dec 11, 2024

  1. test: os.Unsetenv affects global state (#5)

    * test: os.Unsetenv affects global state
    
    This change adds a helper function that guarantees the cleanup of
    environment variables.
    
    For each applicable test function, we run this at the start, and at the
    end through a `defer` keyword. Previously, we were unsetting the
    environment variable within the test, though there is a risk that since
    global state is being manipulated, we may run into a flakey test where
    an environment variable is inadvertently lingering.
    
    * test: use unsetEnv helper to manage global state
    
    ---------
    
    Co-authored-by: James Telfer <[email protected]>
    therealvio and jamestelfer authored Dec 11, 2024
    Copy the full SHA
    3ccb905 View commit details

Commits on Dec 18, 2024

  1. fix: remove duplicate logging (#17)

    * refactor: rename module
    
    Renamed the Go module to match the repo name.
    
    * fix: remove duplicate logging
    
    Errors are now wrapped and returned to the caller, rather than logged
    and returned to the caller.
    
    Propagating the error to the caller causes errors to logged by the
    `main` function (if they're propagated that far). Logging them elsewhere
    results in the error being logged more than once.
    ctgardner authored Dec 18, 2024
    Copy the full SHA
    871ed33 View commit details
Loading