-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: cultureamp/example-go-buildkite-plugin
base: v0.1.0
head repository: cultureamp/example-go-buildkite-plugin
compare: main
- 7 commits
- 16 files changed
- 5 contributors
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40983c3 - Browse repository at this point
Copy the full SHA 40983c3View commit details
Commits on Dec 3, 2024
-
chore: tweaks following end-to-end verification (#2)
* chore: releases may be locally tested, avoid committing these * docs: BK plugin env vars are named after the plugin * chore(goreleaser): update schema to v2 * refactor: plugin linting is the more accurate description of workflow * fix: dangling ecr-scan-results plugin test config
Configuration menu - View commit details
-
Copy full SHA for e82c2cf - Browse repository at this point
Copy the full SHA e82c2cfView commit details
Commits on Dec 4, 2024
-
chore(deps): add renovate.json5 (#4)
Co-authored-by: cultureamp-renovate[bot] <89962466+cultureamp-renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8e6a47d - Browse repository at this point
Copy the full SHA 8e6a47dView commit details -
test: match error string when the environment variable is missing (#3)
* chore: envConfig overrides Buildkite plugin prefixing * test: match the error string when the env var is missing This change fixes a test that returns a false-positive. This occurred because previously the check was for *any* error, not specifically if the required environment variable was missing. This is fixed by checking the error message, rather than naively checking for any error.
Configuration menu - View commit details
-
Copy full SHA for b05c8b4 - Browse repository at this point
Copy the full SHA b05c8b4View commit details
Commits on Dec 5, 2024
-
ci: update linting config (#1)
* ci: update linting config These changes have been copied from cultureamp/ecs-task-runner-buildkite-plugin#3 * ci: disable gci linter This linter isn't required because Go includes built-in functionality for sorting import statements.
Configuration menu - View commit details
-
Copy full SHA for 95f23d2 - Browse repository at this point
Copy the full SHA 95f23d2View commit details
Commits on Dec 11, 2024
-
test: os.Unsetenv affects global state (#5)
* test: os.Unsetenv affects global state This change adds a helper function that guarantees the cleanup of environment variables. For each applicable test function, we run this at the start, and at the end through a `defer` keyword. Previously, we were unsetting the environment variable within the test, though there is a risk that since global state is being manipulated, we may run into a flakey test where an environment variable is inadvertently lingering. * test: use unsetEnv helper to manage global state --------- Co-authored-by: James Telfer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3ccb905 - Browse repository at this point
Copy the full SHA 3ccb905View commit details
Commits on Dec 18, 2024
-
fix: remove duplicate logging (#17)
* refactor: rename module Renamed the Go module to match the repo name. * fix: remove duplicate logging Errors are now wrapped and returned to the caller, rather than logged and returned to the caller. Propagating the error to the caller causes errors to logged by the `main` function (if they're propagated that far). Logging them elsewhere results in the error being logged more than once.
Configuration menu - View commit details
-
Copy full SHA for 871ed33 - Browse repository at this point
Copy the full SHA 871ed33View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.1.0...main