Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOWN ISSUE: problem with picture - support webp #83

Closed
MaudeFJ opened this issue Aug 13, 2024 · 35 comments
Closed

KNOWN ISSUE: problem with picture - support webp #83

MaudeFJ opened this issue Aug 13, 2024 · 35 comments
Assignees
Labels
bug Question Signé Laval Issues reported on Singé Laval's website
Milestone

Comments

@MaudeFJ
Copy link

MaudeFJ commented Aug 13, 2024

Team:
ISSUE: images changed from being the actual image to a pure white image at some point.

Maude added some events (Here is a link to them) last week and added the image displayed below. However, when she checked back the image that appeared was a white image (not the image she added). Can you please check the logs to see what happened?
Note, she updated the image today, August 13th at around noon. The events were created at two different times, one in July, the other two August 7th.
Best guess is the issue happened sometime between August 7 and august 12.

Original request from Maude

https://cms.footlight.io/dashboard/63457978637093005071a053/events/add-event/66aa662e508ed10064fba5fb
This event and all the related one have withe image...
Even tho this is the image I put in when I updated it last week
IMAGE REMOVED BECAUSE TOO LARGE

@MaudeFJ
Copy link
Author

MaudeFJ commented Aug 13, 2024

Je vais modifier l'événement à l'instant mais je voulais vous avertir

@troughc
Copy link

troughc commented Aug 13, 2024

@MaudeFJ what was the issue with the image that you fixed? What was the problem exactly?
thanks.

@troughc troughc self-assigned this Aug 13, 2024
@MaudeFJ
Copy link
Author

MaudeFJ commented Aug 13, 2024

It was all white !

@troughc
Copy link

troughc commented Aug 13, 2024

withe = white, merci! 👍

@troughc
Copy link

troughc commented Aug 13, 2024

@MaudeFJ I have updated the description at the top and will assign to the team to investigate. Please take a look. thanks.

@troughc troughc assigned AbhishekPAnil and unassigned troughc Aug 13, 2024
@troughc troughc added bug Signé Laval Issues reported on Singé Laval's website labels Aug 13, 2024
@troughc troughc assigned sahalali and unassigned AbhishekPAnil Sep 3, 2024
@sahalali sahalali assigned dev-aravind and unassigned dev-aravind Sep 5, 2024
@sahalali
Copy link

sahalali commented Sep 9, 2024

This looks like an image server issue:

This image URL is returning a blank image.

The URL displays almost a blank screen however, the image in S3 is good. I could not find anything interesting from the image server's log.

S3 URl: s3://footlight-images/05566315-fb72-4167-8d0b-4820938a86c1.jpg
CMS: https://cdn.footlight.io/iiif/3/05566315-fb72-4167-8d0b-4820938a86c1.jpg/full/max/0/default.jpg

@saumier Lets discuss this in detail today.

@sahalali
Copy link

sahalali commented Sep 9, 2024

The image looks like something other than jpeg. Can you please provide the original image uploaded?

@sahalali sahalali assigned troughc and unassigned sahalali Sep 9, 2024
@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 9, 2024

VivreEnsemble-affiche (1)
Capture d’écran, le 2024-08-13 à 11 34 59

@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 9, 2024

These are the 2 pictures i have in my files

@troughc troughc assigned sahalali and unassigned troughc Sep 10, 2024
@troughc
Copy link

troughc commented Sep 10, 2024

@sahalali please see Maude's images.

@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 12, 2024

I dont know if this is related but i also have a prob with those pic..
Capture d’écran, le 2024-09-12 à 13 32 38

@sahalali
Copy link

Action item:

  1. File a bug in cantaloupe project

The CMYK JPEG images are not supported currently supported by cantaloupe server.

@troughc
Copy link

troughc commented Sep 17, 2024

Action: Add an message informing user that uploaded image is not supported (pop-up in english and french UIs) that blocks user from adding unsupported image formats.
Caitlin to add message text here - after we determine what approach to take. Potential message will be something like this:
CMYK images are not supported. Convert the colour space to RGB before uploading or choose a different image.

@sahalali sahalali removed their assignment Sep 17, 2024
@troughc troughc assigned troughc and unassigned AbhishekPAnil Sep 18, 2024
@troughc troughc added this to the CC 2024.1 milestone Nov 18, 2024
@troughc troughc removed the backlog label Nov 18, 2024
@AbhishekPAnil
Copy link

cc @AbhishekPAnil will explore the available packages for converting various image formats to JPEG.

@saumier
Copy link
Member

saumier commented Nov 20, 2024

Some feedback for this issue. Please check for support in image server for these formats like .webp. The manipulation of images is the responsibility of the image server. For maintenance and support it makes sense to support more image formats if they can be supported by image server rather than add exceptional conversion code in our CMS code.

@troughc
Copy link

troughc commented Nov 22, 2024

First line of attack: please find out if we can support this format. (webp) in the image server.

@troughc troughc changed the title KNOWN ISSUE: problem with picture KNOWN ISSUE: problem with picture - support webp Nov 22, 2024
@saumier
Copy link
Member

saumier commented Nov 22, 2024

Note: The format .webp is being used by about 15% of websites according this website
https://w3techs.com/technologies/details/im-webp#:~:text=WebP%20is%20used%20by%2014.4%25%20of%20all%20the%20websites.

@AbhishekPAnil AbhishekPAnil removed their assignment Nov 29, 2024
@troughc troughc removed this from the CC 2024.1 milestone Dec 3, 2024
@troughc
Copy link

troughc commented Dec 19, 2024

@sahalali please take this one up.

@troughc troughc added this to the CC 2024.3 milestone Dec 20, 2024
@troughc troughc removed the estimate needed This should be estimated by a developer so it can prioritised label Dec 20, 2024
@sahalali sahalali assigned dev-aravind and unassigned sahalali Jan 2, 2025
@dev-aravind
Copy link

@sahalali Assigning this to you as the development part is completed. The PR can be found here.

@dev-aravind dev-aravind assigned sahalali and unassigned dev-aravind Jan 6, 2025
@troughc
Copy link

troughc commented Jan 6, 2025

Note: webp images will be converted to jpeg, which will resolve this issue.
cc @sahalali

@saumier
Copy link
Member

saumier commented Jan 6, 2025

@dev-aravind Please add link to issue of Cantaloupe. Thx.

@sahalali
Copy link

sahalali commented Jan 6, 2025

There is an open issue in the Cantaloupe project to add support for WebP format images.
cantaloupe-project/cantaloupe#710

cc @saumier

@saumier
Copy link
Member

saumier commented Jan 7, 2025

@sahalali Thx for the link to cantaloupe#710.

I looked at the description and it is related to exporting WebP format not inputing WebP. The example given is /iiif/2/tq%2F566%2Fym%2F4557%2Fargo-logo.jp2/full/802,/0/default.webp which outputs default.webp. Our use case is for the Cantaloupe server to input a WebP and output a default.jpg for display in the CMS or website of our clients.

Can you check again for that? Co-pilot is telling to add processor.webp = Java2DProcessor to the cantaloupe.properties file. And if that does not work then to check if we have

<dependency>
    <groupId>com.luciad</groupId>
    <artifactId>webp-imageio</artifactId>
    <version>0.2.0</version>
</dependency>

@sahalali sahalali removed their assignment Jan 8, 2025
@dev-aravind
Copy link

@sahalali @saumier I found the issue with the webp images that mentions support in the earlier version. Please have a read and let me know what you guys think.

Also @saumier I tried the solution in your comment but it seems like the code for webp support is missing.

@dev-aravind dev-aravind assigned sahalali and saumier and unassigned dev-aravind Jan 8, 2025
@troughc
Copy link

troughc commented Jan 8, 2025

@MaudeFJ we found a way to support these types of images (webp) -- we are converting them to JPEG further upstream from the CMS. Our approach may change in the future, but the issue is fixed and should no longer be happening.
Closing this issue.

@troughc troughc closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Question Signé Laval Issues reported on Singé Laval's website
Projects
None yet
Development

No branches or pull requests

6 participants