Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon padding #95

Open
mchowdhury opened this issue Oct 31, 2024 · 6 comments
Open

Fix icon padding #95

mchowdhury opened this issue Oct 31, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@mchowdhury
Copy link

mchowdhury commented Oct 31, 2024

Great app, I love using it!

There is a minor issue where the padding around logo on the main icon as well of the shortcut actions don't match the Android guidelines. The guidelines recommend 18dp of padding around the icon and the edge of the circle.

See the screenshot below where the all the other icons respect the 18dp padding rule and flashdim icon has almost no padding.

@cyb3rko cyb3rko added the enhancement New feature or request label Oct 31, 2024
@cyb3rko
Copy link
Owner

cyb3rko commented Oct 31, 2024

Hi Mikhail, thanks for the feedback.
I'm not really experienced with designing, but I will try my best at fixing this when I find some time.

@cyb3rko
Copy link
Owner

cyb3rko commented Nov 13, 2024

I have adopted the minimum 18dp recommendation:

Not a big change though


For reference, that's how the previous version looks like with guide lines:

@cyb3rko
Copy link
Owner

cyb3rko commented Nov 13, 2024

I have to take a look at the adaptive icon implementation, maybe there's something wrong...

@cyb3rko
Copy link
Owner

cyb3rko commented Nov 13, 2024

@mchowdhury Does that look as intended?

@mchowdhury
Copy link
Author

@cyb3rko Looks great! Can you check that the the shortcut icons (Minimum, Maximum Brightness, etc.) have the correct padding too?

@cyb3rko
Copy link
Owner

cyb3rko commented Nov 13, 2024

Perfect, I'll try my best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants