Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Failure at all costs #2

Open
charlesetc opened this issue May 29, 2018 · 3 comments
Open

Avoid Failure at all costs #2

charlesetc opened this issue May 29, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@charlesetc
Copy link
Collaborator

We use Failure to match against splice — instead move to a custom defined exception
@cyrus-
Copy link
Owner

cyrus- commented Oct 4, 2018

Is this still open?

@charlesetc
Copy link
Collaborator Author

I'm not sure sure how we do it, but we do run the challenge that if something shadows the Failure constructor relit stops working, so... we should probably find a way.

@cyrus-
Copy link
Owner

cyrus- commented Oct 5, 2018

should be able to locally define a different exception pretty easily I think?

@cyrus- cyrus- added the bug Something isn't working label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyrus- @charlesetc