Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative of gatekeeper test on Windows #49

Open
katrinleinweber opened this issue May 10, 2019 · 2 comments
Open

Add alternative of gatekeeper test on Windows #49

katrinleinweber opened this issue May 10, 2019 · 2 comments
Labels
system checks ✔️ check your local system settings

Comments

@katrinleinweber
Copy link
Contributor

Thank you for your ROpenSci community call presentation recently :-)

Is your feature request related to a problem? Please describe.
I ran ropsec::summarize_system_checks() on Windows 8 and got

macos-simple-test.R:45: error: gatekeeer is on
'spctl' not found
1: system("spctl --status", intern = TRUE) at C:/.../R/win-library/3.6/ropsec/tests/simple/macos-simple-test.R:45

which is no surprise. Same sessionInfo() as in defender/#20.

Describe the solution you'd like

This test should be skipped on Windows systems.

Describe alternatives you've considered

  1. wrap macos-simple-test.R in os_type or a new is_macos
  2. add tests for whatever is Windows Gatekeeper-equivalent

Additional context

@czeildi czeildi added the system checks ✔️ check your local system settings label May 19, 2019
@czeildi
Copy link
Owner

czeildi commented May 19, 2019

Thanks! If you'd like, you are very welcome to submit a PR.

@czeildi
Copy link
Owner

czeildi commented Jul 4, 2019

For now I suppressed these tests with e61ece1 but did not yet provide an alternative. I'll edit the issue accordingly

@czeildi czeildi removed the bug 🐛 label Jul 4, 2019
@czeildi czeildi changed the title Supress gatekeeper test on Windows Add alternative of gatekeeper test on Windows Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system checks ✔️ check your local system settings
Projects
None yet
Development

No branches or pull requests

2 participants