Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is page prop called page? #300

Open
ChocolateLoverRaj opened this issue Aug 3, 2022 · 0 comments
Open

Why is page prop called page? #300

ChocolateLoverRaj opened this issue Aug 3, 2022 · 0 comments

Comments

@ChocolateLoverRaj
Copy link

Is your feature request related to a problem? Please describe.
I got confused by the "page" prop because when I think of page I think of pagination, like this image:
pagination
Then when I tried it out I realized that it doesn't call loadMore in batches (which is good because I want to handle api fetching with my own logic).

Describe the solution you'd like
Maybe rename the "page" related props and variables to "index"

Describe alternatives you've considered
Call param "index" in own code

<InfiniteScroll
  loadMore={index => {}}
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant