New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the dark mode social icons result in an undefined srcset value creating broken images. #124

Open

gitdagray opened this issue Nov 25, 2023 · 0 comments

Contributor

gitdagray commented Nov 25, 2023

Some of the dark mode social icons result in an undefined srcset value which results in broken images.

For example:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="undefined" />
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/socials/hashnode.svg" />
  <img src="https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/socials/hashnode.svg" width="32" height="32" />
</picture>

When deployed, displaying this in dark mode results in a broken image.

I will submit a pull request to fix.

The text was updated successfully, but these errors were encountered:

gitdagray mentioned this issue

Added missing dark-mode social icons, Added darkPath for the icons to… #125

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment