Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☔ Support for hot reload in DDC #54934

Open
sigmundch opened this issue Feb 15, 2024 · 0 comments
Open

☔ Support for hot reload in DDC #54934

sigmundch opened this issue Feb 15, 2024 · 0 comments
Assignees
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@sigmundch
Copy link
Member

sigmundch commented Feb 15, 2024

This is a meta issue to track any individual work towards support for hot reload in DDC.

All line items are tracking in https://github.com/orgs/dart-lang/projects/96/ – this is just meant to be used as an overall tracker.

Last updated: Dec 16, 2024

@sigmundch sigmundch added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Feb 15, 2024
@kevmoo kevmoo changed the title Support for hot reload in DDC META: Support for hot reload in DDC Dec 16, 2024
@kevmoo kevmoo added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Dec 16, 2024
@kevmoo kevmoo changed the title META: Support for hot reload in DDC 👍 META: Support for hot reload in DDC Dec 17, 2024
@kevmoo kevmoo changed the title 👍 META: Support for hot reload in DDC ☔ Support for hot reload in DDC Dec 17, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this issue Jan 9, 2025
…ormat (#161276)

This gets us closer to enabling [hot
reload](dart-lang/sdk#54934) on the web as
this format is a prerequisite. Historically, we added support for the
DDC module format only to enable hot reload, but that format is not
feasible for the goal, so we added the DDC library bundle format. The
DDC library bundle format is currently represented as the combination of
the `ddc` module format and `canary`. We no longer need to support the
old DDC module format.

- Adds build artifacts to build the SDKs for this format (but only in
sound mode as unsound is unsupported), and removes said artifacts for
the DDC module format.
- Update artifact maps and constants to add the new format and remove
the old format.
- Adds handling of the `canaryFeatures` flag.
- Update dwds to 24.3.0 and use the new
`FrontendServerDdcLibraryBundleStrategyProvider`.
- Add bootstrap code for the new format. Kept DDC module format
bootstrap code as it's used internally.
- Updates tests.

I ran `spinning_square` with the new module format to verify that it can
run.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Development

No branches or pull requests

3 participants