-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark #1
Comments
First of all: Are we porting point-in-polygon or the more specialized version point-in-polygon-hao (which supports holes I think)? |
It is as the link to the library implies, the Hao version. |
Do we need "compatibility" the non-HAO version? OR in other words, is it "downwards" compatible? |
As far as I can tell based on the usages of the function in Boolean functions of Turf, only Hao's algorithm is used and there is no consideration of backward compatibility. |
If we only need HAO, then let's do just this for the beginning. Thanks for clarifying! :) |
Just for the record: We currently have only one commented-out benchmark that leads to a dart-format error in the pipeline. In preparation for release 0.0.2 I have removed the not implemented benchmark. If this is important for this issue again, we have the git history. |
In its test, the original library uses several other JS libraries. https://github.com/rowanwins/point-in-polygon-hao/blob/master/test/bench.js
What should we do about them you think, @lukas-h?
The text was updated successfully, but these errors were encountered: