Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #1

Open
armantorkzaban opened this issue Jul 1, 2022 · 6 comments
Open

Benchmark #1

armantorkzaban opened this issue Jul 1, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@armantorkzaban
Copy link
Contributor

In its test, the original library uses several other JS libraries. https://github.com/rowanwins/point-in-polygon-hao/blob/master/test/bench.js
What should we do about them you think, @lukas-h?

@lukas-h
Copy link
Member

lukas-h commented Jul 1, 2022

First of all: Are we porting point-in-polygon or the more specialized version point-in-polygon-hao (which supports holes I think)?

@armantorkzaban
Copy link
Contributor Author

It is as the link to the library implies, the Hao version.

@lukas-h
Copy link
Member

lukas-h commented Jul 1, 2022

Do we need "compatibility" the non-HAO version? OR in other words, is it "downwards" compatible?

@armantorkzaban
Copy link
Contributor Author

As far as I can tell based on the usages of the function in Boolean functions of Turf, only Hao's algorithm is used and there is no consideration of backward compatibility.
If there is a special place where I need to read please let me know.
Otherwise the (ported) function detects Points on the edge, inside and outside of a Polygon.

@lukas-h
Copy link
Member

lukas-h commented Jul 3, 2022

If we only need HAO, then let's do just this for the beginning. Thanks for clarifying! :)

@jsiedentop
Copy link
Contributor

Just for the record: We currently have only one commented-out benchmark that leads to a dart-format error in the pipeline. In preparation for release 0.0.2 I have removed the not implemented benchmark. If this is important for this issue again, we have the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants