-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure restricted view in project settings #690
Comments
What is the status of the issue and Sipi's one? One of our projets ( Any idea how we could proceed? |
You can already set this in the permissions for each image. Just set I don't think it makes sense to make Sipi responsible for this, because you want to distinguish between known and unknown users. Sipi doesn't have that information, but Knora does. Or is the issue that you want to make it impossible for project members to create images with different permissions? |
Yes, but the current permission The idea for this projet is that the permission For some project, the current RV resolution is fine. But some projects want to define the maximum resolution for the images Sipi is providing (let's say during an embargo period, for example). Hence the idea that is should be configurable at the project level:
|
The meaning of "restricted view" is programmable in Sipi. You can make it return images with any size you like, or with watermarks. See the function When #874 is implemented, Sipi will get the project ID as part of the image request URL. So your custom Sipi script will even be able to change the meaning of "restricted view" per project. |
That is a very good news. Given that #874 is scheduled for february milestone, the timing is just perfect for us. Wonderful. Thanks! |
OK, now that I know it's a priority for you, it'll be the next thing I work on. |
Actually, the meaning of It is not feasible to change the deployment configuration of Sipi for each new project that is added. This information will need to be provided by |
So, yes, we will need a new set of properties for the project. Maybe something like this?
|
I was thinking that if they run their own Sipi instance, they can do whatever they want with it. Their Lua pre-flight script can have an Longer term, I see your point, we don’t want project-specific configuration in a centralised Sipi instance. |
Yes, we could do that as a workaround. But anyway, if I understand correctly, we have to wait until #874 is implemented. And can you make a guess on when the longer-term solution could be implemented (just wondering)? |
I hope I can begin working on it next week. |
Thanks to you two. |
A rudimentary implementation is done in #1197. It allows specifying a restricted view size property in the project. This value (if set) is then used in Sipi's preflight script instead of the one in settings. After I merge this PR, I will make a new Knora release. |
I originally created this issue in Sipi repository #224 as a reminder of a discussion with @lrosenth a few weeks ago.
Some project will need to define the maximum resolution allowed for their publicly available images. Due to some restrictions, some projects are allowed to display images : their resolution should be good enough for the unknown user to view but not good enough to make further image processing treatments interesting for this user.
@lrosenth talked about a configuration script for Sipi per project. That would imply to create a new property in Knora to deal with this file in (I guess) admin data.
The text was updated successfully, but these errors were encountered: