Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary fix for the 'should create a resource with values' test #153

Closed
subotic opened this issue Feb 27, 2020 · 1 comment · Fixed by #154
Closed

Add temporary fix for the 'should create a resource with values' test #153

subotic opened this issue Feb 27, 2020 · 1 comment · Fixed by #154
Assignees

Comments

@subotic
Copy link
Contributor

subotic commented Feb 27, 2020

I've commented out the test in a previous PR. A new PR should create a temporary fix (e.g., change the test data before running the test) until the underlying problem is solved.

@tobiasschweizer wrote:

FAILED TESTS:
2457
  ResourcesEndpoint
2458
    method createResource
2459
      ✖ should create a resource with values
2460
        HeadlessChrome 80.0.3987 (Linux 0.0.0)
2461
      Error: Expected $['http://0.0.0.0:3333/ontology/0001/anything/v2#hasDecimal']['http://api.knora.org/ontology/knora-api/v2#decimalValueAsDecimal']['@value'] = '1.5' to equal '100000000000000.000000000000001'.
2462
          at <Jasmine>
2463
          at UserContext.<anonymous> (src/api/v2/resource/resources-endpoint.spec.ts:243:36 <- src/api/v2/resource/resources-endpoint.spec.js:290:48)
2464
          at <Jasmine>
2465

This is a problem with precision in JavaScript (#126).

@tobiasschweizer
Copy link
Contributor

ok, I will try do do that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants